You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "James Strachan (JIRA)" <ji...@apache.org> on 2007/08/25 09:00:22 UTC
[jira] Created: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
--------------------------------------------------------------------------------------------------------------------------------------------
Key: CAMEL-123
URL: https://issues.apache.org/activemq/browse/CAMEL-123
Project: Apache Camel
Issue Type: Improvement
Reporter: James Strachan
Assignee: James Strachan
Fix For: 1.2.0
e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-123:
---------------------------------
Assignee: Claus Ibsen
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Assignee: Claus Ibsen
> Fix For: 2.0.0
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49245#action_49245 ]
Claus Ibsen commented on CAMEL-123:
-----------------------------------
[13:22] <jstrachan> cibsen: with all this consumer v route v UOW; we maybe need a review of all that code really - as when we allow for routes to be started/stopped as independent things it might change things a bit
[13:23] <cibsen> yeah
[13:24] <cibsen> there is a gremlin lying there waiting when starting/stopping routes is more dynamic
[13:24] <cibsen> I will park my work and attach a patch to the ticket
[13:26] <jstrachan> yeah
[13:26] <jstrachan> might have a big impact when we try add that
[13:26] <jstrachan> it'd be great if we can keep all the big impacts inside the core common impl of camel rather than having component/endpoint developers having to worry about it
[13:29] <cibsen> +1
[13:29] <cibsen> yeah I wanted the UoW stuff for components as well so they can register custom code for clean up
[13:29] <jstrachan> yeah!
[13:29] <jstrachan> however that works - we need a nice simple API the component developers can use
[13:30] <jstrachan> then we can tinker under the covers to figure out how it works
[13:30] <jstrachan> (whether using real spring transactions, or UOW or whatever)
[13:30] <jstrachan> maybe we should just use spring transactions for example?
[13:30] <cibsen> I also thoght that we needed a nice DSL in the route: from(x).onComplete(process).to(zzz)
[13:30] <jstrachan> and just kinda make transactions look like a transaction manager?
[13:30] <jstrachan> though then there's the transaction context propogating threads issue etc
[13:30] <jstrachan> yeah
[13:31] <jstrachan> we might also want to be able to start/stop routes by ID too
[13:31] <cibsen> yeah i think we should stick with Spring TX
[13:31] <jstrachan> yeah
[13:31] <cibsen> its to comple to roll out your own
[13:31] <jstrachan> lets do it :)
[13:31] <jstrachan> yeah
[13:31] <jstrachan> then we'd just need a file transaction manager
[13:31] <jstrachan> or some kinda 'simple local transaction manager' for non-tx resources
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Assignee: Claus Ibsen
> Fix For: 2.0.0
>
> Attachments: CAMEL-123_work_in_progress.patch
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48850#action_48850 ]
Claus Ibsen commented on CAMEL-123:
-----------------------------------
The File components could benefit from this so they will hook into UOW and get a onComplete or onFailure callbacks.
These components handle it themself today using try .. catch logic.
I might as well take on this one and use the file component as use-case. For starters the API can be exposed internally/spi and later we can consider some nice DSL supports so you can attach custom code to be invoked.
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Fix For: 2.0.0
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41768#action_41768 ]
Claus Ibsen commented on CAMEL-123:
-----------------------------------
James any update/status on this? Is there some work pending?
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Fix For: 1.3.0
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49236#action_49236 ]
Claus Ibsen commented on CAMEL-123:
-----------------------------------
We got a catch-22 situation
UnitOfWorkProcessor set up the add/remove synchronzation callbacks but they are lazy created just before the Exchange is processed.
So in another component/consumer component/producer you can not add the synchronization before its processed.
But you need to use the async processor and do it in the callback done method.
Need to look into this some more. The idea is also to expose some nice methods in the DSL so end users can add their own custom processing, such as being able to send an email, log or whatever an exchange is done/failed.
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Assignee: Claus Ibsen
> Fix For: 2.0.0
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-123.
-------------------------------
Resolution: Duplicate
Fix Version/s: (was: 2.1.0)
2.0.0
Assignee: Claus Ibsen
CAMEL-1604 implements this feature
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Assignee: Claus Ibsen
> Fix For: 2.0.0
>
> Attachments: CAMEL-123_work_in_progress.patch
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-123:
------------------------------
Component/s: camel-core
Fix Version/s: (was: 2.0.0)
2.1.0
We need a bit more time on this one, and I want to narrow down on a milestone build of Camel 2.0
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 2.1.0
>
> Attachments: CAMEL-123_work_in_progress.patch
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-123:
------------------------------
Attachment: CAMEL-123_work_in_progress.patch
A work in progress patch.
We need to step back and rethink this one. James have some good ideas.
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Assignee: Claus Ibsen
> Fix For: 2.0.0
>
> Attachments: CAMEL-123_work_in_progress.patch
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-123:
---------------------------------
Assignee: (was: Claus Ibsen)
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: James Strachan
> Fix For: 2.1.0
>
> Attachments: CAMEL-123_work_in_progress.patch
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49235#action_49235 ]
Claus Ibsen commented on CAMEL-123:
-----------------------------------
UnitOfWork is only weaven into the route if you use the route builder.
For manual code such as creating a consumer from an endpoint will not inject the UoW
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Assignee: Claus Ibsen
> Fix For: 2.0.0
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40043 ]
James Strachan commented on CAMEL-123:
--------------------------------------
have added a UnitOfWork object on an Exchange which can act as the registration point for onComplete / onFailure callbacks - it just needs to be wired into the sync/async processing changes Hiram made yesterday
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Assignee: James Strachan
> Fix For: 1.2.0
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Strachan updated CAMEL-123:
---------------------------------
Fix Version/s: (was: 1.2.0)
1.3.0
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Assignee: James Strachan
> Fix For: 1.3.0
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-123) add an 'on commit / on rollback' hook
so that non-transactional components can do things like delete files when
the processing has completed
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Strachan updated CAMEL-123:
---------------------------------
Assignee: (was: James Strachan)
> add an 'on commit / on rollback' hook so that non-transactional components can do things like delete files when the processing has completed
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-123
> URL: https://issues.apache.org/activemq/browse/CAMEL-123
> Project: Apache Camel
> Issue Type: Improvement
> Reporter: James Strachan
> Fix For: 1.3.0
>
>
> e.g. file / FTP should only delete the file after successful processing has occurred etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.