[GitHub] [apisix-ingress-controller] neverCase edited a comment on pull request #689: feat: init ApisixPluginConfig crd (#638)

[GitBox <gi...@apache.org>]

neverCase edited a comment on pull request #689:
URL: https://github.com/apache/apisix-ingress-controller/pull/689#issuecomment-926536613


   > @neverCase you should re-run `make codegen` and push it.
   > 
   > ```
   > make codegen
   > git add pkg/*
   > git commit -m 're-run codegen'
   > git push 
   > ```
   
   should i add `ApisixPluginConfigList` first.
   There some errors in the pkg/kube/apisix/client/clientset/versioned/typed/config/v2beta1/apisixpluginconfig.go
   ```sh
   // List takes label and field selectors, and returns the list of ApisixPluginConfigs that match those selectors.
   func (c *apisixPluginConfigs) List(ctx context.Context, opts v1.ListOptions) (result *v2beta1.ApisixPluginConfigList, err error) {
   	var timeout time.Duration
   	if opts.TimeoutSeconds != nil {
   		timeout = time.Duration(*opts.TimeoutSeconds) * time.Second
   	}
   	result = &v2beta1.ApisixPluginConfigList{}
   	err = c.client.Get().
   		Namespace(c.ns).
   		Resource("apisixpluginconfigs").
   		VersionedParams(&opts, scheme.ParameterCodec).
   		Timeout(timeout).
   		Do(ctx).
   		Into(result)
   	return
   }
   ```
   The structure `ApisixPluginConfigList` maybe be required.
   @tao12345666333 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org