You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/16 14:29:38 UTC

[GitHub] [activemq-artemis] erwindon opened a new pull request #3495: spacing in logmessage

erwindon opened a new pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495


   a specific log message lists a few terms. 2 of these terms do not have any spacing between them as I noticed in actual output,
   2 additional spacing adjustments for consistency.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3495: spacing in logmessage

Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495#discussion_r595345278



##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
##########
@@ -154,7 +154,7 @@ public URI toBackupURI() {
 
    @Override
    public String toString() {
-      return "TopologyMember[id = " + nodeId + ", connector=" + connector + ", backupGroupName=" + backupGroupName + ", scaleDownGroupName=" + scaleDownGroupName + "]";
+      return "TopologyMember[id=" + nodeId + ", connector=" + connector + ", backupGroupName=" + backupGroupName + ", scaleDownGroupName=" + scaleDownGroupName + "]";

Review comment:
       Is this change on purpose?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on pull request #3495: spacing in logmessage

Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495#issuecomment-800417808


   If you are applying the same style `padding-left: 10px` to all divs with the `input-group-btn` class you could define that class in the https://github.com/apache/activemq-artemis/blob/master/artemis-hawtio/activemq-branding/src/main/webapp/plugin/css/activemq.css


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3495: spacing in logmessage

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495#discussion_r595230403



##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/services/toolbar.js
##########
@@ -25,7 +25,7 @@ var Artemis;
                     <form class="toolbar-pf-actions">
                         <div class="form-group toolbar-pf-filter">
                             <div class="input-group">
-                                <div class="input-group-btn">
+                                <div class="input-group-btn" style="padding-left: 10px">

Review comment:
       @andytaylor can you review this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] erwindon commented on a change in pull request #3495: spacing in logmessage

Posted by GitBox <gi...@apache.org>.
erwindon commented on a change in pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495#discussion_r595382443



##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
##########
@@ -154,7 +154,7 @@ public URI toBackupURI() {
 
    @Override
    public String toString() {
-      return "TopologyMember[id = " + nodeId + ", connector=" + connector + ", backupGroupName=" + backupGroupName + ", scaleDownGroupName=" + scaleDownGroupName + "]";
+      return "TopologyMember[id=" + nodeId + ", connector=" + connector + ", backupGroupName=" + backupGroupName + ", scaleDownGroupName=" + scaleDownGroupName + "]";

Review comment:
       yes, though cosmetic. the other items in the same message do not have spacing around the "="




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] asfgit closed pull request #3495: spacing in logmessage

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev removed a comment on pull request #3495: spacing in logmessage

Posted by GitBox <gi...@apache.org>.
brusdev removed a comment on pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495#issuecomment-800417808


   If you are applying the same style `padding-left: 10px` to all divs with the `input-group-btn` class you could define that class in the https://github.com/apache/activemq-artemis/blob/master/artemis-hawtio/activemq-branding/src/main/webapp/plugin/css/activemq.css


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] erwindon commented on a change in pull request #3495: spacing in logmessage

Posted by GitBox <gi...@apache.org>.
erwindon commented on a change in pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495#discussion_r595381098



##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/services/toolbar.js
##########
@@ -25,7 +25,7 @@ var Artemis;
                     <form class="toolbar-pf-actions">
                         <div class="form-group toolbar-pf-filter">
                             <div class="input-group">
-                                <div class="input-group-btn">
+                                <div class="input-group-btn" style="padding-left: 10px">

Review comment:
       sorry, the HTML code should not have been here, see comment below




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] erwindon commented on pull request #3495: spacing in logmessage

Posted by GitBox <gi...@apache.org>.
erwindon commented on pull request #3495:
URL: https://github.com/apache/activemq-artemis/pull/3495#issuecomment-800452703


   I have to apologize deeply here!
   Due to a faulty rebase, this PR contained also code from another PR.
   None of the HTML changes were supposed to be here.
   That has now been corrected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org