You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2020/06/23 08:21:39 UTC
[maven-resolver] branch MRESOLVER-127 created (now fcf6a8f)
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a change to branch MRESOLVER-127
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git.
at fcf6a8f [MRESOLVER-127] Don't use boolean for property 'aether.updateCheckManager.sessionState'
This branch includes the following new commits:
new fcf6a8f [MRESOLVER-127] Don't use boolean for property 'aether.updateCheckManager.sessionState'
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[maven-resolver] 01/01: [MRESOLVER-127] Don't use boolean for
property 'aether.updateCheckManager.sessionState'
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch MRESOLVER-127
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git
commit fcf6a8f90383a819b37f10965f77b92657905e94
Author: Michael Osipov <mi...@siemens.com>
AuthorDate: Tue Jun 23 10:21:04 2020 +0200
[MRESOLVER-127] Don't use boolean for property 'aether.updateCheckManager.sessionState'
This closes #62
---
.../eclipse/aether/internal/impl/DefaultUpdateCheckManager.java | 4 ++--
.../aether/internal/impl/DefaultUpdateCheckManagerTest.java | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java
index e7f2c8e..f1892c5 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java
@@ -446,8 +446,8 @@ public class DefaultUpdateCheckManager
private int getSessionState( RepositorySystemSession session )
{
- String mode = ConfigUtils.getString( session, "true", CONFIG_PROP_SESSION_STATE );
- if ( Boolean.parseBoolean( mode ) )
+ String mode = ConfigUtils.getString( session, "enabled", CONFIG_PROP_SESSION_STATE );
+ if ( Boolean.parseBoolean( mode ) || "enabled".equalsIgnoreCase( mode ) )
{
// perform update check at most once per session, regardless of update policy
return STATE_ENABLED;
diff --git a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java
index 8ca42c0..27d4719 100644
--- a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java
+++ b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java
@@ -8,9 +8,9 @@ package org.eclipse.aether.internal.impl;
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -338,11 +338,11 @@ public class DefaultUpdateCheckManagerTest
resetSessionData( session );
manager.touchMetadata( session, check );
- session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "true" );
+ session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "enabled" );
manager.checkMetadata( session, check );
assertEquals( false, check.isRequired() );
- session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "false" );
+ session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "disabled" );
manager.checkMetadata( session, check );
assertEquals( true, check.isRequired() );
}