You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2013/11/23 14:19:14 UTC
module log id missing for main.c
(maybe sf already knows something about this)
[Thu Nov 21 16:20:17.035427 2013] [:emerg] [pid 1237:tid 47440161182336]
AH00017: Pre-configuration failed, exiting
Maybe main.c isn't a module, but it is probably best to put "core" there.
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: module log id missing for main.c
Posted by Jeff Trawick <tr...@gmail.com>.
On Sat, Nov 23, 2013 at 12:00 PM, Rainer Jung <ra...@kippdata.de>wrote:
> On 23.11.2013 14:19, Jeff Trawick wrote:
> > (maybe sf already knows something about this)
> >
> > [Thu Nov 21 16:20:17.035427 2013] [:emerg] [pid 1237:tid 47440161182336]
> > AH00017: Pre-configuration failed, exiting
> >
> > Maybe main.c isn't a module, but it is probably best to put "core" there.
>
> Some other server/*.c files do it like this:
>
> --- server/main.c (revision 1544810)
> +++ server/main.c (working copy)
> @@ -50,6 +50,10 @@
> #define isatty(n) (0)
> #endif
>
> +/* we know core's module_index is 0 */
> +#undef APLOG_MODULE_INDEX
> +#define APLOG_MODULE_INDEX AP_CORE_MODULE_INDEX
> +
> /* WARNING: Win32 binds http_main.c dynamically to the server. Please
> place
> * extern functions and global data in another appropriate
> module.
> *
>
>
> It does add "core" into the log line, but not sure whether that would be
> correct for anything logged from inside main.c. I'd say "yes".
>
> Regards,
>
> Rainer
>
works for me, committed as r1547065
Thanks!
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: module log id missing for main.c
Posted by Jeff Trawick <tr...@gmail.com>.
On Sat, Nov 23, 2013 at 5:23 PM, Stefan Fritsch <sf...@sfritsch.de> wrote:
> Am Samstag, 23. November 2013, 18:00:40 schrieb Rainer Jung:
> > On 23.11.2013 14:19, Jeff Trawick wrote:
> > > (maybe sf already knows something about this)
> > >
> > > [Thu Nov 21 16:20:17.035427 2013] [:emerg] [pid 1237:tid
> > > 47440161182336] AH00017: Pre-configuration failed, exiting
> > >
> > > Maybe main.c isn't a module, but it is probably best to put "core"
> > > there.
> > Some other server/*.c files do it like this:
> >
> > --- server/main.c (revision 1544810)
> > +++ server/main.c (working copy)
> > @@ -50,6 +50,10 @@
> > #define isatty(n) (0)
> > #endif
> >
> > +/* we know core's module_index is 0 */
> > +#undef APLOG_MODULE_INDEX
> > +#define APLOG_MODULE_INDEX AP_CORE_MODULE_INDEX
> > +
> > /* WARNING: Win32 binds http_main.c dynamically to the server.
> > Please place * extern functions and global data in another
> > appropriate module. *
> >
> >
> > It does add "core" into the log line, but not sure whether that
> > would be correct for anything logged from inside main.c. I'd say
> > "yes".
>
> There is r952783:
> ===========================================
> Author: Stefan Fritsch <sf...@apache.org>
> Date: Tue Jun 8 19:30:24 2010 +0000
>
> remove APLOG_USE_MODULE from main.c:
> It causes build problems on Windows and the ap_log* calls in main.c
> don't profit from it anyway, because there is no server_rec yet where
> they could look up core_module's loglevel.
> ===========================================
>
>
> I don't remember the Windows details. Maybe using AP_CORE_MODULE_INDEX
> (which was really introduced as optimization) instead of
> APLOG_USE_MODULE(core) fixes those problems. If yes, do it.
>
>
Thanks, guys! I'll go through the Windows testing "soon" .
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: module log id missing for main.c
Posted by Stefan Fritsch <sf...@sfritsch.de>.
Am Samstag, 23. November 2013, 18:00:40 schrieb Rainer Jung:
> On 23.11.2013 14:19, Jeff Trawick wrote:
> > (maybe sf already knows something about this)
> >
> > [Thu Nov 21 16:20:17.035427 2013] [:emerg] [pid 1237:tid
> > 47440161182336] AH00017: Pre-configuration failed, exiting
> >
> > Maybe main.c isn't a module, but it is probably best to put "core"
> > there.
> Some other server/*.c files do it like this:
>
> --- server/main.c (revision 1544810)
> +++ server/main.c (working copy)
> @@ -50,6 +50,10 @@
> #define isatty(n) (0)
> #endif
>
> +/* we know core's module_index is 0 */
> +#undef APLOG_MODULE_INDEX
> +#define APLOG_MODULE_INDEX AP_CORE_MODULE_INDEX
> +
> /* WARNING: Win32 binds http_main.c dynamically to the server.
> Please place * extern functions and global data in another
> appropriate module. *
>
>
> It does add "core" into the log line, but not sure whether that
> would be correct for anything logged from inside main.c. I'd say
> "yes".
There is r952783:
===========================================
Author: Stefan Fritsch <sf...@apache.org>
Date: Tue Jun 8 19:30:24 2010 +0000
remove APLOG_USE_MODULE from main.c:
It causes build problems on Windows and the ap_log* calls in main.c
don't profit from it anyway, because there is no server_rec yet where
they could look up core_module's loglevel.
===========================================
I don't remember the Windows details. Maybe using AP_CORE_MODULE_INDEX
(which was really introduced as optimization) instead of
APLOG_USE_MODULE(core) fixes those problems. If yes, do it.
Re: module log id missing for main.c
Posted by Rainer Jung <ra...@kippdata.de>.
On 23.11.2013 14:19, Jeff Trawick wrote:
> (maybe sf already knows something about this)
>
> [Thu Nov 21 16:20:17.035427 2013] [:emerg] [pid 1237:tid 47440161182336]
> AH00017: Pre-configuration failed, exiting
>
> Maybe main.c isn't a module, but it is probably best to put "core" there.
Some other server/*.c files do it like this:
--- server/main.c (revision 1544810)
+++ server/main.c (working copy)
@@ -50,6 +50,10 @@
#define isatty(n) (0)
#endif
+/* we know core's module_index is 0 */
+#undef APLOG_MODULE_INDEX
+#define APLOG_MODULE_INDEX AP_CORE_MODULE_INDEX
+
/* WARNING: Win32 binds http_main.c dynamically to the server. Please place
* extern functions and global data in another appropriate module.
*
It does add "core" into the log line, but not sure whether that would be
correct for anything logged from inside main.c. I'd say "yes".
Regards,
Rainer