You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "BaseMax (via GitHub)" <gi...@apache.org> on 2023/08/25 19:42:49 UTC

[GitHub] [tvm] BaseMax opened a new pull request, #15620: Change == to === operator in compact.ts file

BaseMax opened a new pull request, #15620:
URL: https://github.com/apache/tvm/pull/15620

   Hi Apache Team,
   
   I'm thrilled to submit my eighth contribution to Apache! I've addressed the issue of weak comparing == inside the compact.ts. Paying attention to such details is vital for code quality, and I'm committed to enhancing the project.
   
   **Description:**
   Change the comparison operator `==` to `===` in the `compact.ts` file for improved type checking and accuracy.
   
   **Changes:**
   - Replaced `==` with `===` operator for more strict equality comparison.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #15620: Change == to === operator in compact.ts file

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #15620:
URL: https://github.com/apache/tvm/pull/15620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15620: Change == to === operator in compact.ts file

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15620:
URL: https://github.com/apache/tvm/pull/15620#issuecomment-1693848937

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org