You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@druid.apache.org by Julian Jaffe <ju...@gmail.com> on 2021/04/14 06:50:54 UTC
Re: Spark-Druid Connectors
Hey Gian and other Druids,
Is there anything I can do to encourage reviews of this code? Would a dev guide or design doc be helpful to reviewers? Can I bribe someone with chocolate :)?
Thanks,
Julian
> On Mar 2, 2021, at 9:53 AM, Gian Merlino <gi...@apache.org> wrote:
>
> Thank you!
>
>> On Thu, Feb 25, 2021 at 12:03 AM Julian Jaffe <ju...@gmail.com>
>> wrote:
>>
>> Hey Gian,
>>
>> I’d be overjoyed to be proven wrong! For what it’s worth, my pessimism was
>> not driven by a lack of faith in the Druid community or the Druid
>> committers but by the fact that these connectors may be an awkward fit in
>> the Druid code base without more buy-in from the community writ large.
>>
>> The information you’re asking for is spread across a few places. I’ll
>> consolidate it into the PR, emphasizing the UX and the tests. I should have
>> it up within a day or so.
>>
>> Thanks,
>> Julian
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
>> For additional commands, e-mail: dev-help@druid.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org
Re: Spark-Druid Connectors
Posted by Julian Jaffe <ju...@gmail.com>.
Bimonthly ping for reviews :) I’m perfectly willing to hop on Slack or a video call to walk through the code and design as well if potential reviewers would find that helpful.
> On Apr 14, 2021, at 10:06 AM, Julian Jaffe <ju...@gmail.com> wrote:
>
>
> Hey Samarth,
>
> I’m overjoyed to hear that! The PR is here: https://github.com/apache/druid/pull/10920. I’ll add you as a reviewer as well when I have a moment.
>
> Thanks,
> Julian
>
>>> On Apr 14, 2021, at 12:09 AM, Samarth Jain <sa...@apache.org> wrote:
>>>
>> Hi Julian,
>>
>> I would be happy to review your Spark-Druid connector PRs. Ingesting data
>> into Druid using Spark SQL and Dataframe API is something we are very keen
>> to onboard.
>> Could you point me to them or alternatively add me as a reviewer?
>>
>> - Samarth
>>
>> On Tue, Apr 13, 2021 at 11:51 PM Julian Jaffe <ju...@gmail.com>
>> wrote:
>>
>>> Hey Gian and other Druids,
>>>
>>> Is there anything I can do to encourage reviews of this code? Would a dev
>>> guide or design doc be helpful to reviewers? Can I bribe someone with
>>> chocolate :)?
>>>
>>> Thanks,
>>> Julian
>>>
>>>>> On Mar 2, 2021, at 9:53 AM, Gian Merlino <gi...@apache.org> wrote:
>>>>
>>>> Thank you!
>>>>
>>>>> On Thu, Feb 25, 2021 at 12:03 AM Julian Jaffe <ju...@gmail.com>
>>>>> wrote:
>>>>>
>>>>> Hey Gian,
>>>>>
>>>>> I’d be overjoyed to be proven wrong! For what it’s worth, my pessimism
>>> was
>>>>> not driven by a lack of faith in the Druid community or the Druid
>>>>> committers but by the fact that these connectors may be an awkward fit
>>> in
>>>>> the Druid code base without more buy-in from the community writ large.
>>>>>
>>>>> The information you’re asking for is spread across a few places. I’ll
>>>>> consolidate it into the PR, emphasizing the UX and the tests. I should
>>> have
>>>>> it up within a day or so.
>>>>>
>>>>> Thanks,
>>>>> Julian
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
>>>>> For additional commands, e-mail: dev-help@druid.apache.org
>>>>>
>>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
>>> For additional commands, e-mail: dev-help@druid.apache.org
>>>
>>>
Re: Spark-Druid Connectors
Posted by Julian Jaffe <ju...@gmail.com>.
Hey Samarth,
I’m overjoyed to hear that! The PR is here: https://github.com/apache/druid/pull/10920. I’ll add you as a reviewer as well when I have a moment.
Thanks,
Julian
> On Apr 14, 2021, at 12:09 AM, Samarth Jain <sa...@apache.org> wrote:
>
> Hi Julian,
>
> I would be happy to review your Spark-Druid connector PRs. Ingesting data
> into Druid using Spark SQL and Dataframe API is something we are very keen
> to onboard.
> Could you point me to them or alternatively add me as a reviewer?
>
> - Samarth
>
>> On Tue, Apr 13, 2021 at 11:51 PM Julian Jaffe <ju...@gmail.com>
>> wrote:
>>
>> Hey Gian and other Druids,
>>
>> Is there anything I can do to encourage reviews of this code? Would a dev
>> guide or design doc be helpful to reviewers? Can I bribe someone with
>> chocolate :)?
>>
>> Thanks,
>> Julian
>>
>>>> On Mar 2, 2021, at 9:53 AM, Gian Merlino <gi...@apache.org> wrote:
>>>
>>> Thank you!
>>>
>>>> On Thu, Feb 25, 2021 at 12:03 AM Julian Jaffe <ju...@gmail.com>
>>>> wrote:
>>>>
>>>> Hey Gian,
>>>>
>>>> I’d be overjoyed to be proven wrong! For what it’s worth, my pessimism
>> was
>>>> not driven by a lack of faith in the Druid community or the Druid
>>>> committers but by the fact that these connectors may be an awkward fit
>> in
>>>> the Druid code base without more buy-in from the community writ large.
>>>>
>>>> The information you’re asking for is spread across a few places. I’ll
>>>> consolidate it into the PR, emphasizing the UX and the tests. I should
>> have
>>>> it up within a day or so.
>>>>
>>>> Thanks,
>>>> Julian
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
>>>> For additional commands, e-mail: dev-help@druid.apache.org
>>>>
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
>> For additional commands, e-mail: dev-help@druid.apache.org
>>
>>
Re: Spark-Druid Connectors
Posted by Samarth Jain <sa...@apache.org>.
Hi Julian,
I would be happy to review your Spark-Druid connector PRs. Ingesting data
into Druid using Spark SQL and Dataframe API is something we are very keen
to onboard.
Could you point me to them or alternatively add me as a reviewer?
- Samarth
On Tue, Apr 13, 2021 at 11:51 PM Julian Jaffe <ju...@gmail.com>
wrote:
> Hey Gian and other Druids,
>
> Is there anything I can do to encourage reviews of this code? Would a dev
> guide or design doc be helpful to reviewers? Can I bribe someone with
> chocolate :)?
>
> Thanks,
> Julian
>
> > On Mar 2, 2021, at 9:53 AM, Gian Merlino <gi...@apache.org> wrote:
> >
> > Thank you!
> >
> >> On Thu, Feb 25, 2021 at 12:03 AM Julian Jaffe <ju...@gmail.com>
> >> wrote:
> >>
> >> Hey Gian,
> >>
> >> I’d be overjoyed to be proven wrong! For what it’s worth, my pessimism
> was
> >> not driven by a lack of faith in the Druid community or the Druid
> >> committers but by the fact that these connectors may be an awkward fit
> in
> >> the Druid code base without more buy-in from the community writ large.
> >>
> >> The information you’re asking for is spread across a few places. I’ll
> >> consolidate it into the PR, emphasizing the UX and the tests. I should
> have
> >> it up within a day or so.
> >>
> >> Thanks,
> >> Julian
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
> >> For additional commands, e-mail: dev-help@druid.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
> For additional commands, e-mail: dev-help@druid.apache.org
>
>