You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/04/04 19:32:12 UTC

Review Request 20031: PIG_OPTS should be appended instead of being over written

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20031/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-5352
    https://issues.apache.org/jira/browse/AMBARI-5352


Repository: ambari


Description
-------

When tez is enabled the following code is executed in pig-env.sh

    
    
    if [ -d "/usr/lib/tez" ]; then
      PIG_OPTS="-Dmapreduce.framework.name=yarn"
    fi
    

We should be appending to PIG_OPTS and not overwriting it.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/templates/pig-env.sh.j2 6e82ef2 

Diff: https://reviews.apache.org/r/20031/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 20031: PIG_OPTS should be appended instead of being over written

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20031/#review39559
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On April 4, 2014, 5:32 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20031/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 5:32 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-5352
>     https://issues.apache.org/jira/browse/AMBARI-5352
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When tez is enabled the following code is executed in pig-env.sh
> 
>     
>     
>     if [ -d "/usr/lib/tez" ]; then
>       PIG_OPTS="-Dmapreduce.framework.name=yarn"
>     fi
>     
> 
> We should be appending to PIG_OPTS and not overwriting it.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/templates/pig-env.sh.j2 6e82ef2 
> 
> Diff: https://reviews.apache.org/r/20031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>