You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2021/08/18 13:18:45 UTC

[Bug 65506] New: Wrong conditional on WsSession checkExpiration

https://bz.apache.org/bugzilla/show_bug.cgi?id=65506

            Bug ID: 65506
           Summary: Wrong conditional on WsSession checkExpiration
           Product: Tomcat 9
           Version: 9.0.52
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P2
         Component: WebSocket
          Assignee: dev@tomcat.apache.org
          Reporter: gustavo.mahlow@cvortex.io
  Target Milestone: -----

Created attachment 37983
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37983&action=edit
Buggy conditional

There's a invalid conditional on WsSession checkExpiration method.

The conditional that checks if the write timeout expired, is checking if the
diff of now and lastActiveWrite is bigger than "timeoutRead".

else if (timeoutWrite > 0 && (currentTime - lastActiveWrite) > timeoutRead)

The comparison should check if is bigger than "timeoutWrite" not "timeoutRead".

The correct behavior should be the following:

else if (timeoutWrite > 0 && (currentTime - lastActiveWrite) > timeoutWrite)

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 65506] Wrong conditional on WsSession checkExpiration

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65506

--- Comment #1 from Remy Maucherat <re...@apache.org> ---
Ok, I will fix that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 65506] Wrong conditional on WsSession checkExpiration

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65506

Remy Maucherat <re...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Remy Maucherat <re...@apache.org> ---
Thanks, the fix will be in 10.1.0-M5, 10.0.11, 9.0.53, 8.5.71.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org