You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/10/21 00:51:48 UTC
[GitHub] [solr] turnertg opened a new pull request #358: SOLR-15700: Make include paths in bin/solr consistent
turnertg opened a new pull request #358:
URL: https://github.com/apache/solr/pull/358
https://issues.apache.org/jira/browse/SOLR-15700
# Description
In the `bin/solr` bash script, the header comment specifies which paths are searched for the environment file `solr.in.sh`, however this does not match the logic that actually finds and includes the file. This results in unexpected behavior if the user is packaging Solr to run under `/var/solr`, and the fairly common `/etc/default` path is undocumented. Both of these paths are already used in the reference guide, namely [Taking Solr to Production](https://github.com/apache/solr/blob/main/solr/solr-ref-guide/src/taking-solr-to-production.adoc) and [Upgrading a Solr Cluster](https://github.com/apache/solr/blob/main/solr/solr-ref-guide/src/upgrading-a-solr-cluster.adoc).
# Solution
Added `/etc/default` to the script's header comment (was only in logic) and added `/var/solr` to the `for` loop (was only in comment) for consistency.
# Tests
- Tested against a Solr 8.10.1 host and verified each `solr.in.sh` include path took precedence as required.
- Verified logic using bash's `-x` debug flag with a command along the lines of `sudo -u solr /usr/bin/bash -x /usr/bin/solr status` to check status and create a few test cores without issue.
- There are currently no tests in `bin-test/solr` checking for environment information or expected paths, but performing these without root is slightly thorny and likely out of scope for this particular issue.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #358: SOLR-15700: Make include paths in bin/solr consistent
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #358:
URL: https://github.com/apache/solr/pull/358#issuecomment-965075092
@turnertg I responsed to @janhoy feedback, and added attribution. Is `turnertg` work? I'd like to merge this tomorrow!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #358: SOLR-15700: Make include paths in bin/solr consistent
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #358:
URL: https://github.com/apache/solr/pull/358#issuecomment-950140950
@turnertg can you update this in response to @janhoy feedback and I'd love to get this merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #358: SOLR-15700: Make include paths in bin/solr consistent
Posted by GitBox <gi...@apache.org>.
epugh merged pull request #358:
URL: https://github.com/apache/solr/pull/358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org