You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Piotr Nowojski (Jira)" <ji...@apache.org> on 2022/10/14 12:06:00 UTC
[jira] [Commented] (FLINK-13876) Remove ExecutionConfig field from PojoSerializer
[ https://issues.apache.org/jira/browse/FLINK-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617675#comment-17617675 ]
Piotr Nowojski commented on FLINK-13876:
----------------------------------------
I'm not sure, but if this is a really issue, that's not solved by {{PojoSerializerSnapshot}} or {{PojoSerializerConfigSnapshot}}, then FLINK-19084 would be a braking change already.
> Remove ExecutionConfig field from PojoSerializer
> ------------------------------------------------
>
> Key: FLINK-13876
> URL: https://issues.apache.org/jira/browse/FLINK-13876
> Project: Flink
> Issue Type: Improvement
> Components: API / Type Serialization System
> Affects Versions: 1.7.2, 1.8.1, 1.9.0, 1.10.0
> Reporter: Dawid Wysakowicz
> Priority: Minor
> Labels: auto-deprioritized-major
> Fix For: 1.17.0
>
>
> The PojoSerializers stores an instance of ExecutionConfig as internal field, even though that the only information it may ever need are the registered kryo serializers.
> This has a few drawbacks:
> * It blocks the evolution of {{ExecutionConfig}} as serializers where stored in a state. Therefore any change to ExecutionConfig must be backwards compatible in respect to java serialization
> * It probably already introduced a bug, as upon restore the Snapshot actually recreates the serializer with an empty ExecutionConfig (see org.apache.flink.api.java.typeutils.runtime.PojoSerializerSnapshot#restoreSerializer)
> I suggest to remove the field completely and adjust corresponding usages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)