You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/02/26 09:12:35 UTC

[GitHub] spark pull request #20670: [SPARK-23405] Add constranits

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20670#discussion_r170528989
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala ---
    @@ -29,12 +29,26 @@ trait QueryPlanConstraints { self: LogicalPlan =>
        */
       lazy val constraints: ExpressionSet = {
         if (conf.constraintPropagationEnabled) {
    +      var relevantOutPutSet: AttributeSet = outputSet
    +      constraints.foreach {
    +        case eq @ EqualTo(l: Attribute, r: Attribute) =>
    --- End diff --
    
    `eq` isn't used


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org