[jira] [Commented] (NIFI-2624) JDBC-to-Avro processors handle BigDecimals as Strings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15580269#comment-15580269 ] 

ASF GitHub Bot commented on NIFI-2624:
--------------------------------------

GitHub user ToivoAdams opened a pull request:

    https://github.com/apache/nifi/pull/1142

    NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logical type usin…

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    …g bytes to hold data (not String as is was before).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ToivoAdams/nifi nifi-2624b

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1142
    
----
commit 4d6de9663087ebb30041341c8d55de01c4af3875
Author: Toivo Adams <to...@gmail.com>
Date:   2016-10-16T17:15:33Z

    NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logical type using bytes to hold data (not String as is was before).

----


> JDBC-to-Avro processors handle BigDecimals as Strings
> -----------------------------------------------------
>
>                 Key: NIFI-2624
>                 URL: https://issues.apache.org/jira/browse/NIFI-2624
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Toivo Adams
>
> The original SQL processors implemented BigDecimal values as Strings for 
> Avro, as the version of Avro it used (1.7.6) did not support DECIMAL type.
> As of Avro 1.7.7 (AVRO-1402), this type is supported and so the SQL/HiveQL processors should be updated to handle BigDecimals correctly if possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)