You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (JIRA)" <ji...@apache.org> on 2011/08/29 17:32:41 UTC
[jira] [Created] (THRIFT-1305) thrift: make TConnection a private
inner class of
thrift: make TConnection a private inner class of
---------------------------------------------------
Key: THRIFT-1305
URL: https://issues.apache.org/jira/browse/THRIFT-1305
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
Attachments: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
>From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
From: Adam Simpkins <si...@fb.com>
Date: Mon, 19 Apr 2010 19:09:13 +0000
Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
TNonblockingServer
Summary:
The immediate need for this is so that TConnection can access some
protected methods of TNonblockingServer. However, it
seems a generally good thing to eliminate TConnection from the publicly
exposed API.
Test Plan:
Ran the tests from [fb unittest].
Revert Plan:
OK
Conflicts:
lib/cpp/src/server/TNonblockingServer.cpp
lib/cpp/src/server/TNonblockingServer.h
---
lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
2 files changed, 291 insertions(+), 285 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1305) thrift: make TConnection a private
inner class of
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1305.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.8
Assignee: Dave Watson
Committed.
> thrift: make TConnection a private inner class of
> ---------------------------------------------------
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 19 Apr 2010 19:09:13 +0000
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
> TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer. However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
> lib/cpp/src/server/TNonblockingServer.cpp
> lib/cpp/src/server/TNonblockingServer.h
> ---
> lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
> lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
> 2 files changed, 291 insertions(+), 285 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1305) thrift: make TConnection a private
inner class of
Posted by "Dave Watson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Watson updated THRIFT-1305:
--------------------------------
Attachment: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
> thrift: make TConnection a private inner class of
> ---------------------------------------------------
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Priority: Minor
> Attachments: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 19 Apr 2010 19:09:13 +0000
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
> TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer. However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
> lib/cpp/src/server/TNonblockingServer.cpp
> lib/cpp/src/server/TNonblockingServer.h
> ---
> lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
> lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
> 2 files changed, 291 insertions(+), 285 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1305) thrift: make TConnection a private
inner class of
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1305.
---------------------------------
Resolution: Fixed
I just committed your patch, Alexandre.
> thrift: make TConnection a private inner class of
> ---------------------------------------------------
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch, thrift-1305-2.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 19 Apr 2010 19:09:13 +0000
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
> TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer. However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
> lib/cpp/src/server/TNonblockingServer.cpp
> lib/cpp/src/server/TNonblockingServer.h
> ---
> lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
> lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
> 2 files changed, 291 insertions(+), 285 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (THRIFT-1305) thrift: make TConnection a private
inner class of
Posted by "alexandre parenteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
alexandre parenteau reopened THRIFT-1305:
-----------------------------------------
This change reverted in part THRIFT-1217 changes (use of evutil_socketpair). Please find attached a patch thrift-1305-2.patch which re-introduces those changes. Tested on Ubuntu and Windows. Thanks!
> thrift: make TConnection a private inner class of
> ---------------------------------------------------
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 19 Apr 2010 19:09:13 +0000
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
> TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer. However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
> lib/cpp/src/server/TNonblockingServer.cpp
> lib/cpp/src/server/TNonblockingServer.h
> ---
> lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
> lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
> 2 files changed, 291 insertions(+), 285 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1305) thrift: make TConnection a
private inner class of
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093188#comment-13093188 ]
Hudson commented on THRIFT-1305:
--------------------------------
Integrated in Thrift #243 (See [https://builds.apache.org/job/Thrift/243/])
THRIFT-1305. cpp: make TConnection a private inner class of
TNonblockingServer
Patch: Adam Simpkins
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1162987
Files :
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.h
> thrift: make TConnection a private inner class of
> ---------------------------------------------------
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 19 Apr 2010 19:09:13 +0000
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
> TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer. However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
> lib/cpp/src/server/TNonblockingServer.cpp
> lib/cpp/src/server/TNonblockingServer.h
> ---
> lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
> lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
> 2 files changed, 291 insertions(+), 285 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1305) thrift: make TConnection a private
inner class of
Posted by "alexandre parenteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
alexandre parenteau updated THRIFT-1305:
----------------------------------------
Attachment: thrift-1305-2.patch
>From THRIFT-1217
> thrift: make TConnection a private inner class of
> ---------------------------------------------------
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch, thrift-1305-2.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 19 Apr 2010 19:09:13 +0000
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
> TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer. However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
> lib/cpp/src/server/TNonblockingServer.cpp
> lib/cpp/src/server/TNonblockingServer.h
> ---
> lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
> lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
> 2 files changed, 291 insertions(+), 285 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1305) thrift: make TConnection a
private inner class of
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095460#comment-13095460 ]
Hudson commented on THRIFT-1305:
--------------------------------
Integrated in Thrift #245 (See [https://builds.apache.org/job/Thrift/245/])
THRIFT-1305. cpp: make TConnection a private inner class of
TNonblockingServer
The previous patch reverted some elements of THRIFT-1217. Fixed.
Patch: Alexandre Parenteau
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1164161
Files :
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.h
> thrift: make TConnection a private inner class of
> ---------------------------------------------------
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch, thrift-1305-2.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 19 Apr 2010 19:09:13 +0000
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
> TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer. However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
> lib/cpp/src/server/TNonblockingServer.cpp
> lib/cpp/src/server/TNonblockingServer.h
> ---
> lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
> lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
> 2 files changed, 291 insertions(+), 285 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira