You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/26 10:48:39 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request, #243: [FLINK-28692] Check warehouse path in CatalogFactory
JingsongLi opened a new pull request, #243:
URL: https://github.com/apache/flink-table-store/pull/243
- Not exist, automatic creating the directory.
- Exist but it is not directory, throw exception.
- Exist and it is a directory, pass...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #243: [FLINK-28692] Check warehouse path in CatalogFactory
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #243:
URL: https://github.com/apache/flink-table-store/pull/243#discussion_r929819943
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/CatalogFactory.java:
##########
@@ -69,6 +74,21 @@ static Catalog createCatalog(Configuration options) {
.collect(Collectors.joining("\n")));
}
+ try {
+ Path warehousePath = new Path(warehouse);
+ FileSystem fs = warehousePath.getFileSystem();
+ if (fs.exists(warehousePath)) {
+ checkArgument(
+ fs.getFileStatus(warehousePath).isDir(),
+ "Warehouse path '%s' should be a directory.",
Review Comment:
```suggestion
"%s path '%s' should be a directory.", WAREHOUSE.key()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #243: [FLINK-28692] Check warehouse path in CatalogFactory
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #243:
URL: https://github.com/apache/flink-table-store/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org