You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/08/18 16:03:49 UTC
Review Request 61743: Use latest-vdf for default when version is
unspecified
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61743/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-21756
https://issues.apache.org/jira/browse/AMBARI-21756
Repository: ambari
Description
-------
Use a new construction in hdp_urlinfo.json ("latest-vdf") that indicates what the latest release is for a stack. This will be used in Blueprints when the version is NOT known NOR added to the DB before-hand.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 2cecfb650a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ea592e50af
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java ddc7c60ece
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 3c7c0016ef
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java d77d13c00b
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 63cb21ffa8
ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java fc4fa868b5
ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/hdp.json 708d757fe5
ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/repoinfo.xml 031f5fd28a
ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/version-2.2.0.5.xml PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.2.1/metainfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.2.1/repos/hdp.json PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.2.1/repos/repoinfo.xml PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.2.1/services/RANGER/alerts.json PRE-CREATION
Diff: https://reviews.apache.org/r/61743/diff/1/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 61743: Use latest-vdf for default when version is
unspecified
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61743/#review183316
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Aug. 18, 2017, 6:03 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61743/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 6:03 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-21756
> https://issues.apache.org/jira/browse/AMBARI-21756
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Use a new construction in hdp_urlinfo.json ("latest-vdf") that indicates what the latest release is for a stack. This will be used in Blueprints when the version is NOT known NOR added to the DB before-hand.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 2cecfb650a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ea592e50af
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java ddc7c60ece
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 45d8e8e196
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 3c7c0016ef
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java d77d13c00b
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 63cb21ffa8
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 0809d63968
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java cb25aecdeb
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java c9d3d2b7e2
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java fc4fa868b5
> ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/hdp.json 708d757fe5
> ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/repoinfo.xml 031f5fd28a
> ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/version-2.2.0.5.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.2.1/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.2.1/repos/hdp.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.2.1/repos/repoinfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.2.1/services/RANGER/alerts.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61743/diff/2/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4818, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:56.608s
> [INFO] Finished at: Fri Aug 18 13:34:04 EDT 2017
> [INFO] Final Memory: 30M/1991M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 61743: Use latest-vdf for default when version is
unspecified
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61743/#review183241
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
Lines 74 (patched)
<https://reviews.apache.org/r/61743/#comment259262>
I think the preferred way to measure elapsed time is use nanoTime since it doesn't depend on the system clock / resources:
long startTime = System.nanoTime();
...
TimeUnit.NANOSECONDS.toMillis(...)
- Jonathan Hurley
On Aug. 18, 2017, 12:03 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61743/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 12:03 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-21756
> https://issues.apache.org/jira/browse/AMBARI-21756
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Use a new construction in hdp_urlinfo.json ("latest-vdf") that indicates what the latest release is for a stack. This will be used in Blueprints when the version is NOT known NOR added to the DB before-hand.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 2cecfb650a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ea592e50af
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java ddc7c60ece
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 45d8e8e196
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 3c7c0016ef
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java d77d13c00b
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 63cb21ffa8
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 0809d63968
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java cb25aecdeb
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java c9d3d2b7e2
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java fc4fa868b5
> ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/hdp.json 708d757fe5
> ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/repoinfo.xml 031f5fd28a
> ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/version-2.2.0.5.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.2.1/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.2.1/repos/hdp.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.2.1/repos/repoinfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.2.1/services/RANGER/alerts.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61743/diff/2/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4818, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:56.608s
> [INFO] Finished at: Fri Aug 18 13:34:04 EDT 2017
> [INFO] Final Memory: 30M/1991M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>