[jira] [Commented] (TEZ-3654) CartesianProduct edge won't work with GroupInputEdge

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934166#comment-15934166 ] 

TezQA commented on TEZ-3654:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12859699/TEZ-3654.1.patch
  against master revision 293c593.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 11 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 3 new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2337//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/2337//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-library.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2337//console

This message is automatically generated.

> CartesianProduct edge won't work with GroupInputEdge
> ----------------------------------------------------
>
>                 Key: TEZ-3654
>                 URL: https://issues.apache.org/jira/browse/TEZ-3654
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Zhiyuan Yang
>            Assignee: Zhiyuan Yang
>         Attachments: TEZ-3654.1.patch
>
>
> If a vertex group is used as source of cartesian product, it expands into multiple vertices that share the same edge properties and each CP edge is taken as individual cartesian product source by CP vertex manager. CP vertex manager will find there are more CP edge than expected and abort the AM.  
> Ideally group edge semantic should be fixed: both task and vertex manager should see same number of sources; also not every edge can be simply duplicated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)