[GitHub] eiri commented on issue #595: Return 404 when put attachment with nonexistent rev

[gi...@git.apache.org]

eiri commented on issue #595: Return 404 when put attachment with nonexistent rev
URL: https://github.com/apache/couchdb/pull/595#issuecomment-308220014
 
 
   The tests are fine locally and `404` is better than `500`, so the change itself looks good to me.
   
   The only thing is that I'm not 100% sure that we should return `404` and not `409` here. I understand we are crashing with `not_found`, but update of attachment is doc's update and we are throwing 409 on attempt to update doc with non-existing revision. So from consistency perspective we might want to do this here as well.
   
   I'm tentatively +1, but get a second opinion before merging, please.
   
   
   Local tests:
   
   ```bash
   make eunit apps=chttpd
   ...
   =======================================================
     All 150 tests passed.
   ```
   
   ```bash
   make javascript
   ...
   =======================================================
   JavaScript tests complete.
     Failed: 0.  Skipped or passed: 86.
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services