You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ki...@apache.org on 2022/10/12 14:16:16 UTC
[incubator-seatunnel] branch dev updated: [Improve][Common]DeployMode enumeration Generate Map method optimization (#3055)
This is an automated email from the ASF dual-hosted git repository.
kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 4af4d8c3e [Improve][Common]DeployMode enumeration Generate Map method optimization (#3055)
4af4d8c3e is described below
commit 4af4d8c3e989f3602dba7610c2f234028712a13a
Author: Kerwin <37...@users.noreply.github.com>
AuthorDate: Wed Oct 12 22:16:11 2022 +0800
[Improve][Common]DeployMode enumeration Generate Map method optimization (#3055)
* DeployMode enumeration Generate Map method optimization
---
.../apache/seatunnel/common/config/CheckResult.java | 8 +-------
.../org/apache/seatunnel/common/config/DeployMode.java | 18 ++++++++----------
2 files changed, 9 insertions(+), 17 deletions(-)
diff --git a/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/CheckResult.java b/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/CheckResult.java
index 3f0d24c2d..83c6dcf8a 100644
--- a/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/CheckResult.java
+++ b/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/CheckResult.java
@@ -28,13 +28,7 @@ public class CheckResult {
private String msg;
- /**
- * Do not call this constructor directly,
- * please use {@link #success} or {@link #error(String)} instead,
- * will be private in the future
- */
- @Deprecated
- public CheckResult(boolean success, String msg) {
+ private CheckResult(boolean success, String msg) {
this.success = success;
this.msg = msg;
}
diff --git a/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/DeployMode.java b/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/DeployMode.java
index cfc4a9a12..1bc64b385 100644
--- a/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/DeployMode.java
+++ b/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/DeployMode.java
@@ -17,29 +17,27 @@
package org.apache.seatunnel.common.config;
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+
import java.util.Arrays;
-import java.util.HashMap;
import java.util.Map;
import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+@Getter
+@AllArgsConstructor
public enum DeployMode {
CLIENT("client"),
CLUSTER("cluster"),
;
private static final Map<String, DeployMode> NAME_MAP = Arrays.stream(DeployMode.values())
- .collect(HashMap::new, (map, deployMode) -> map.put(deployMode.getName(), deployMode), Map::putAll);
+ .collect(Collectors.toMap(DeployMode::getName, Function.identity()));
private final String name;
- DeployMode(String name) {
- this.name = name;
- }
-
- public String getName() {
- return name;
- }
-
public static Optional<DeployMode> from(String name) {
return Optional.ofNullable(NAME_MAP.get(name.toLowerCase()));
}