You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/02 09:21:49 UTC

[GitHub] [apisix-dashboard] idbeta opened a new issue #954: test: route_with_limit_plugin_test (E2E) may fail

idbeta opened a new issue #954:
URL: https://github.com/apache/apisix-dashboard/issues/954


   # Bug report
   
   when I execute tests in my local environment,somtimes may fail.
   
   ## How to Reproduce
   
   ```
   === RUN   TestRoute_With_Limit_Plugin_By_Consumer
       printer.go:54: GET http://127.0.0.1:9080/hello
       printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/routes/r1
       printer.go:54: GET http://127.0.0.1:9000/apisix/admin/consumers/jack
       printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/consumers
       printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/consumers
       printer.go:54: GET http://127.0.0.1:9080/hello
       printer.go:54: GET http://127.0.0.1:9080/hello
       printer.go:54: GET http://127.0.0.1:9080/hello
       reporter.go:23:
           	Error Trace:	reporter.go:23
           	            				chain.go:21
           	            				response.go:585
           	            				response.go:151
           	            				base.go:184
           	            				route_with_limit_plugin_test.go:302
           	Error:
           	            	expected status equal to:
           	            	 "503 Service Unavailable"
   
           	            	but got:
           	            	 "200 OK"
           	Test:       	TestRoute_With_Limit_Plugin_By_Consumer
   ```
   
   ## Additional context
   
   In this case, the `time_window` of the `limit-count `is `2`, it should be set larger so that it can avoid the case execution failure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen closed issue #954: test: route_with_limit_plugin_test (E2E) may fail

Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #954:
URL: https://github.com/apache/apisix-dashboard/issues/954


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #954: test: route_with_limit_plugin_test (E2E) may fail

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #954:
URL: https://github.com/apache/apisix-dashboard/issues/954#issuecomment-737114168


   `"time_window": 2,` to `"time_window": 60,`, should be enough


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on issue #954: test: route_with_limit_plugin_test (E2E) may fail

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #954:
URL: https://github.com/apache/apisix-dashboard/issues/954#issuecomment-742525730


   we don't have this fail now, should have be fixed by  #976


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org