You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/16 13:24:18 UTC
[GitHub] [rocketmq] Cczzzz opened a new pull request #3496: fix ：#3434
Cczzzz opened a new pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496
I don’t understand why there are changes. I didn’t change the style at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-971092210
@Cczzzz Would you like to change this PR target branch to develop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-971551135
I add license to client/src/test/java/org/apache/rocketmq/client/consumer/HeartbeatServiceTest .but client/src/main/java/org/apache/rocketmq/client/impl/consumer/HeartbeatService Have it already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-975214030
checks fail ， How do i fix it。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-994773554
why closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-971128963
build fail @duhenglucky ,can you help me ? .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-994773739
> why closed
@vongosling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Git-Yang commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-971131479
> build fail @duhenglucky ,can you help me ? .
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project rocketmq-client: Too many files with unapproved license: 1 See RAT report in: /home/travis/build/apache/rocketmq/client/target/rat.txt -> [Help 1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-970340868
[](https://coveralls.io/builds/44333413)
Coverage decreased (-0.02%) to 55.074% when pulling **5bde971ada3a58096e2b53aa182087df9b5b0af9 on Cczzzz:cczz** into **4b8b307901da19a1e562c883adc1bdaf8e111cfb on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Git-Yang edited a comment on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Git-Yang edited a comment on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-971131479
> build fail @duhenglucky ,can you help me ? .
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project rocketmq-client: Too many files with unapproved license: 1 See RAT report in: /home/travis/build/apache/rocketmq/client/target/rat.txt -> [Help 1]
Add license to the head in
client/src/main/java/org/apache/rocketmq/client/impl/consumer/HeartbeatService.java and
client/src/test/java/org/apache/rocketmq/client/consumer/HeartbeatServiceTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-991618239
Who can help me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-991618239
Who can help me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-992135912
> Who can help me
CI check passed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Git-Yang edited a comment on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Git-Yang edited a comment on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-971131479
> build fail @duhenglucky ,can you help me ? .
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project rocketmq-client: Too many files with unapproved license: 1 See RAT report in: /home/travis/build/apache/rocketmq/client/target/rat.txt -> [Help 1]
Add license to the head in client/src/test/java/org/apache/rocketmq/client/consumer/HeartbeatServiceTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling closed pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-971123062
> @Cczzzz Would you like to change this PR target branch to develop?
to dev？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-970281526
> I don’t understand why there are changes. I didn’t change the style at all.
Solved by importing rmq_codeStyle.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3496: fix ：#3434
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3496:
URL: https://github.com/apache/rocketmq/pull/3496#issuecomment-970340868
[](https://coveralls.io/builds/44302180)
Coverage increased (+0.04%) to 54.49% when pulling **41e8e288257864645c50cc06a68a621756671a3e on Cczzzz:cczz** into **df4e98855d461d85e9c4ed43add1b12a58bca7b6 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org