You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/04/15 03:02:49 UTC
[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17321
Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client
......................................................................
KUDU-2612: an extra test for txn keepalive failover in Java client
This is a follow-up to 096f1ddf09047ea11d78a661010dd549ffa9af51.
This patchs adds an extra test scenario similar the one added
in the prior changelist, but with additional twist of "rolling"
unavailability of leader masters. In addition, it verifies that
the RPC error responses from TxnManager due to the unavailability
of TxnStatusManager are properly handled by the Java client.
Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
1 file changed, 104 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/17321/1
--
To view, visit http://gerrit.cloudera.org:8080/17321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
Gerrit-Change-Number: 17321
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17321
to look at the new patch set (#2).
Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client
......................................................................
KUDU-2612: an extra test for txn keepalive failover in Java client
This is a follow-up to 096f1ddf09047ea11d78a661010dd549ffa9af51.
This patchs adds an extra test scenario similar the one added
in the prior changelist, but with additional twist of "rolling"
unavailability of leader masters. In addition, it verifies that
RPC error responses from TxnManager due to the unavailability
of TxnStatusManager are properly handled by the Java client.
Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
1 file changed, 109 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/17321/2
--
To view, visit http://gerrit.cloudera.org:8080/17321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
Gerrit-Change-Number: 17321
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17321
to look at the new patch set (#3).
Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client
......................................................................
KUDU-2612: an extra test for txn keepalive failover in Java client
This is a follow-up to 096f1ddf09047ea11d78a661010dd549ffa9af51.
This patchs adds an extra test scenario similar the one added
in the prior changelist, but with additional twist of "rolling"
unavailability of leader masters. In addition, it verifies that
RPC error responses from TxnManager due to the unavailability
of TxnStatusManager are properly handled by the Java client.
Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
1 file changed, 113 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/17321/3
--
To view, visit http://gerrit.cloudera.org:8080/17321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
Gerrit-Change-Number: 17321
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17321 )
Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17321/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java:
http://gerrit.cloudera.org:8080/#/c/17321/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java@1035
PS1, Line 1035: row
> nit: rows
Done
--
To view, visit http://gerrit.cloudera.org:8080/17321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
Gerrit-Change-Number: 17321
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 15 Apr 2021 05:36:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17321 )
Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Thanks for adding this extra coverage!
http://gerrit.cloudera.org:8080/#/c/17321/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java:
http://gerrit.cloudera.org:8080/#/c/17321/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java@1035
PS1, Line 1035:
nit: rows
--
To view, visit http://gerrit.cloudera.org:8080/17321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
Gerrit-Change-Number: 17321
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 15 Apr 2021 05:16:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17321 )
Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client
......................................................................
KUDU-2612: an extra test for txn keepalive failover in Java client
This is a follow-up to 096f1ddf09047ea11d78a661010dd549ffa9af51.
This patchs adds an extra test scenario similar the one added
in the prior changelist, but with additional twist of "rolling"
unavailability of leader masters. In addition, it verifies that
RPC error responses from TxnManager due to the unavailability
of TxnStatusManager are properly handled by the Java client.
Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
Reviewed-on: http://gerrit.cloudera.org:8080/17321
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
1 file changed, 113 insertions(+), 9 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
Gerrit-Change-Number: 17321
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: an extra test for txn keepalive failover in Java client
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17321 )
Change subject: KUDU-2612: an extra test for txn keepalive failover in Java client
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib278d402bee85fb0442cbce98b2b4ab022229eb4
Gerrit-Change-Number: 17321
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 15 Apr 2021 05:40:14 +0000
Gerrit-HasComments: No