[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #4379: [Bug][Connector-v2][KafkaSource]Fix KafkaConsumerThread exit caused by commit offset error.

["liugddx (via GitHub)" <gi...@apache.org>]

liugddx commented on code in PR #4379:
URL: https://github.com/apache/incubator-seatunnel/pull/4379#discussion_r1142924007


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaConsumerThread.java:
##########
@@ -60,6 +60,9 @@ public void run() {
                 } catch (InterruptedException e) {
                     throw new KafkaConnectorException(
                             KafkaConnectorErrorCode.CONSUME_THREAD_RUN_ERROR, e);
+                } catch (Exception e) {
+                    throw new KafkaConnectorException(
+                            KafkaConnectorErrorCode.CONSUME_THREAD_RUN_ERROR, e);

Review Comment:
   If Exception is used here, does the above catch still make sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org