You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/24 11:38:32 UTC
[GitHub] [spark] Kimahriman opened a new pull request #35959: [SPARK-38640][CORE] Only remove shuffle service tracked RDD
Kimahriman opened a new pull request #35959:
URL: https://github.com/apache/spark/pull/35959
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Fixes a bug where if `spark.shuffle.service.fetch.rdd.enabled=true`, memory-only cached blocks will fail to unpersist.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In https://github.com/apache/spark/pull/33020, when all RDD blocks are removed from `externalShuffleServiceBlockStatus`, the underlying Map is nulled to reduce memory. When persisting blocks we check if it's using disk before adding it to `externalShuffleServiceBlockStatus`, but when removing them there is no check, so a memory-only cache block will keep `externalShuffleServiceBlockStatus` null, and when unpersisting it throw an NPE because it tries to remove from the null Map. This adds checks to the removal as well to only remove if the block is on disk, and therefore should have been added to `externalShuffleServiceBlockStatus` in the first place.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New and updated UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35959: [SPARK-38640][CORE] Only remove shuffle service tracked RDD
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35959:
URL: https://github.com/apache/spark/pull/35959#issuecomment-1077534462
@attilapiros found this while testing https://github.com/apache/spark/pull/35085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35959:
URL: https://github.com/apache/spark/pull/35959#discussion_r841159327
##########
File path: core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala
##########
@@ -255,4 +255,22 @@ class ExternalShuffleServiceSuite extends ShuffleSuite with BeforeAndAfterAll wi
}
}
}
+
+ test("SPARK-38640: using external shuffle service fetching disk persisted blocks") {
Review comment:
I'm wondering if this `disk persisted blocks` correct for this test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35959:
URL: https://github.com/apache/spark/pull/35959#issuecomment-1078276358
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35959:
URL: https://github.com/apache/spark/pull/35959#discussion_r841159044
##########
File path: core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala
##########
@@ -255,4 +255,22 @@ class ExternalShuffleServiceSuite extends ShuffleSuite with BeforeAndAfterAll wi
}
}
}
+
+ test("SPARK-38640: using external shuffle service fetching disk persisted blocks") {
+ val confWithRddFetchEnabled = conf.clone.set(config.SHUFFLE_SERVICE_FETCH_RDD_ENABLED, true)
Review comment:
Shall we test with both `true` and `false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35959:
URL: https://github.com/apache/spark/pull/35959#issuecomment-1078910621
Okay good to know, I'll just change it to that then. Was just overcomplicating things hah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #35959:
URL: https://github.com/apache/spark/pull/35959#issuecomment-1078654857
Why not simply move the `blocks.remove(blockId)` in `BlockStatusPerBlockId.remove` within a `if (null != blocks) ` check ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35959:
URL: https://github.com/apache/spark/pull/35959#issuecomment-1077545449
I wasn't exactly sure what the "right" fix was here that avoided weird edge cases where you change a block from memory only to memory and disk or vice versa. The alternative is adding a null check in `BlockStatusPerBlockId.remove` but I wasn't sure if that was a race condition waiting to happen or if that will only ever be called from one thread. But I guess the `get` would also be a race condition if that was the case, so maybe that's the better alternative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm edited a comment on pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching
Posted by GitBox <gi...@apache.org>.
mridulm edited a comment on pull request #35959:
URL: https://github.com/apache/spark/pull/35959#issuecomment-1078654857
Why not simply move the `blocks.remove(blockId)` in `BlockStatusPerBlockId.remove` within a `if (null != blocks) ` check ?
(Note, all invocations are within a BlockManagerMasterEndpoint event loop - so no MT issues : else all uses of `BlockStatusPerBlockId.blocks` would have been broken :-) ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm edited a comment on pull request #35959: [SPARK-38640][CORE] Fix NPE with memory-only cache blocks and RDD fetching
Posted by GitBox <gi...@apache.org>.
mridulm edited a comment on pull request #35959:
URL: https://github.com/apache/spark/pull/35959#issuecomment-1078654857
Why not simply move the `blocks.remove(blockId)` in `BlockStatusPerBlockId.remove` within a `if (null != blocks) ` check ?
(Note, all invocations are within a BlockManagerMasterEndpoint event loop - so no MT issues).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org