You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/08/15 20:49:02 UTC

[Impala-ASF-CR] IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18852


Change subject: IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone
......................................................................

IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Ozone 1.2 changed the name of its hadoop adapter jar. Logic to link
against the jar in pom.xml was correctly updated, but the jar name used
in HADOOP_CLASSPATH assumed Ozone 1.2. Updates the jar in
HADOOP_CLASSPATH to use the correct jar for the detected Ozone version.

Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18852/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
Gerrit-Change-Number: 18852
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18852 )

Change subject: IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8454/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
Gerrit-Change-Number: 18852
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 00:40:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18852 )

Change subject: IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone
......................................................................


Patch Set 1: Code-Review+2

Looks good, thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/18852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
Gerrit-Change-Number: 18852
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 00:39:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18852 )

Change subject: IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
Gerrit-Change-Number: 18852
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:31:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18852 )

Change subject: IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
Gerrit-Change-Number: 18852
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 00:40:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18852 )

Change subject: IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone
......................................................................

IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Ozone 1.2 changed the name of its hadoop adapter jar. Logic to link
against the jar in pom.xml was correctly updated, but the jar name used
in HADOOP_CLASSPATH assumed Ozone 1.2. Updates the jar in
HADOOP_CLASSPATH to use the correct jar for the detected Ozone version.

Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
Reviewed-on: http://gerrit.cloudera.org:8080/18852
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
Gerrit-Change-Number: 18852
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18852 )

Change subject: IMPALA-9442: (Addendum) Fix Ozone jar name for older Ozone
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11158/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e401075268ebd81af8b8cac72504f0d1a4e59f1
Gerrit-Change-Number: 18852
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 21:09:54 +0000
Gerrit-HasComments: No