[GitHub] [carbondata] kunal642 commented on a change in pull request #3308: [CARBONDATA-3454] optimized index server output for count(*)

[GitBox <gi...@apache.org>]

kunal642 commented on a change in pull request #3308: [CARBONDATA-3454] optimized index server output for count(*)
URL: https://github.com/apache/carbondata/pull/3308#discussion_r324507436
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/AbstractDataMapJob.java
 ##########
 @@ -30,4 +30,8 @@
   @Override public void execute(CarbonTable carbonTable,
       FileInputFormat<Void, BlockletDataMapIndexWrapper> format) {
   }
+
+  @Override public Long executeCountJob(DistributableDataMapFormat dataMapFormat) {
+    return null;
 
 Review comment:
   removed the implementation in AbstractDataMapJob.java, now all the extending classes should give their own implementations

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services