[Impala-ASF-CR] IMPALA-8578: part 2: move metrics code to .cc files

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13501

to look at the new patch set (#3).

Change subject: IMPALA-8578: part 2: move metrics code to .cc files
......................................................................

IMPALA-8578: part 2: move metrics code to .cc files

This moves a lot of metric function definitions into .cc files,
to reduce the size of compilation units and to reduce the
frequency of recompilation required when making changes
to metrics.

This moves most of the large, non-perf-critical metric
functions into .cc files. For template classes, this
requires explicitly instantiating all combinations of
template parameters that are used in impala, including
in tests.

Disable weak-template-vtables warning because of
spurious warnings on template instantiations. See
https://bugs.llvm.org/show_bug.cgi?id=18733

Change-Id: I78ad045ded6e6a7b7524711be9302c26115b97b9
---
M .clang-tidy
M be/src/exprs/expr-test.cc
M be/src/rpc/rpc-trace.cc
M be/src/rpc/rpc-trace.h
M be/src/rpc/thrift-server.cc
M be/src/runtime/bufferpool/reservation-tracker-test.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/io/hdfs-file-reader.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/scheduler.cc
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/util/CMakeLists.txt
M be/src/util/auth-util.cc
A be/src/util/collection-metrics.cc
M be/src/util/collection-metrics.h
M be/src/util/default-path-handlers.cc
A be/src/util/histogram-metric.cc
M be/src/util/histogram-metric.h
M be/src/util/metrics-test.cc
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/webserver.cc
M be/src/util/webserver.h
33 files changed, 620 insertions(+), 458 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/13501/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78ad045ded6e6a7b7524711be9302c26115b97b9
Gerrit-Change-Number: 13501
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>