You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/18 14:43:22 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6593: [AIRFLOW-6000] Fix the test randomly fail - TestCliConnections.test_cli_connections_add_delete

ashb commented on a change in pull request #6593: [AIRFLOW-6000] Fix the test randomly fail - TestCliConnections.test_cli_connections_add_delete
URL: https://github.com/apache/airflow/pull/6593#discussion_r347418648
 
 

 ##########
 File path: tests/cli/test_cli.py
 ##########
 @@ -1329,6 +1329,7 @@ def test_cli_connections_list_redirect(self):
             self.assertEqual(0, proc.returncode)
 
     def test_cli_connections_add_delete(self):
+        db.resetdb()
 
 Review comment:
   Can you add a `# TODO: ...` here so we stand a chance of remembering this if we don't get straight on to the other fix.
   
   The other option would be to mock the Connection adding code -- we don't need to test that here, just the CLI code right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services