You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/02/10 19:00:49 UTC

[GitHub] couchdb-fauxton pull request: Fix for selected text in Ace editor

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/262

    Fix for selected text in Ace editor

    This updates the background color and the location of the selected
    text bg color.
    
    Closes COUCHDB-2573

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton 2573-ace-editor-select-text-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit 3c4572aba263da08026a5b61832ae4bd0a167ebb
Author: Ben Keen <be...@gmail.com>
Date:   2015-02-10T17:57:17Z

    Fix for selected text in Ace editor
    
    This updates the background color and the location of the selected
    text bg color.
    
    Closes COUCHDB-2573

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Fix for selected text in Ace editor

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/262#issuecomment-73894477
  
    Apologies @robertkowalski, you're quite right of course - I keep forgetting this particular file is part of that lib. I'll do that ticket today. Thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Fix for selected text in Ace editor

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/262#issuecomment-73909229
  
    Closing. I'll create a separate ticket that undoes any changes to that file and moves these changes + the previous to our own CSS>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Fix for selected text in Ace editor

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Fix for selected text in Ace editor

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/262#issuecomment-73865917
  
    Hi Ben,
    
    we should never made any changes in external dependencies. If we have to we have to submit a PR to them and then pulling it down after they merged. I also noticed that you already patched internal libraries.
    
    I assigned https://issues.apache.org/jira/browse/COUCHDB-2560 to you, please revert the previous change. Probably that also fixes this issue we currently have. 
    
    If not, you can create an CSS selector in "our" less which is stronger than the one from ace. I remember that you already did that some time ago in `codeeditor.less`
    
    Patching external libraries makes updating them impossible as nobody can tell what happens when we run an update. Please stop doing so - it makes updates unpredictable for the person that updates the external library.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---