You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/03/03 23:36:13 UTC
Review Request 31707: DRILL-2207: New Union-All Implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/
-----------------------------------------------------------
Review request for drill, Aman Sinha and Jinfeng Ni.
Bugs: DRILL-2207
https://issues.apache.org/jira/browse/DRILL-2207
Repository: drill-git
Description
-------
DRILL-2207: New Union-All Implementation
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAll.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllTemplate.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java 7b772cc
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q9.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/31707/diff/
Testing
-------
Design Doc can be found from:
https://issues.apache.org/jira/browse/DRILL-2207
Unit, Customers, TPCH, Functional (still waiting)
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/#review75841
-----------------------------------------------------------
Ship it!
- Aman Sinha
On March 10, 2015, 1:14 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31707/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 1:14 a.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2207
> https://issues.apache.org/jira/browse/DRILL-2207
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2207: New Union-All Implementation
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
> exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
> exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31707/diff/
>
>
> Testing
> -------
>
> Design Doc can be found from:
> https://issues.apache.org/jira/browse/DRILL-2207
>
> Unit, Customers, TPCH passed
> waiting for Functional...
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/
-----------------------------------------------------------
(Updated March 10, 2015, 1:14 a.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
A new patch
Bugs: DRILL-2207
https://issues.apache.org/jira/browse/DRILL-2207
Repository: drill-git
Description
-------
DRILL-2207: New Union-All Implementation
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/31707/diff/
Testing
-------
Design Doc can be found from:
https://issues.apache.org/jira/browse/DRILL-2207
Unit, Customers, TPCH passed
waiting for Functional...
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On March 10, 2015, 12:20 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 346
> > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line346>
> >
> > Remove the 'is' in the first sentence.
Error message changed
> On March 10, 2015, 12:20 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 371
> > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line371>
> >
> > Same as above.
Error message changed
> On March 10, 2015, 12:20 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 423
> > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line423>
> >
> > Miss-match should have one 's'
Error message changed
> On March 10, 2015, 12:20 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 453
> > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line453>
> >
> > Why did you remove the super.cleanup() call ?
I did not remove it. Actually, the line you were referring to is at "the inner class", which is used by the Top-Level Class to do clean up. The cleanup() method of the top-level class still does call super.cleanup().
> On March 10, 2015, 12:20 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java, line 150
> > <https://reviews.apache.org/r/31707/diff/4/?file=888259#file888259line150>
> >
> > I think referencing the 2207 JIRA is misleading here because that one will be marked Fixed once this feature goes in. To avoid confusion, this should either refer to a specific star column bug or not reference the jira.
Agree. The new error message directs users to DRILL-2414, which is specific to this exception.
> On March 10, 2015, 12:20 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 471
> > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line471>
> >
> > This error looks different from what we throw for IterOutcome.NONE in other operators...can you check and make this consistent.
Changed to
throw new IllegalStateException(String.format("Unknown state %s.", upstream));
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/#review75808
-----------------------------------------------------------
On March 10, 2015, 1:14 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31707/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 1:14 a.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2207
> https://issues.apache.org/jira/browse/DRILL-2207
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2207: New Union-All Implementation
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
> exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
> exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31707/diff/
>
>
> Testing
> -------
>
> Design Doc can be found from:
> https://issues.apache.org/jira/browse/DRILL-2207
>
> Unit, Customers, TPCH passed
> waiting for Functional...
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/#review75808
-----------------------------------------------------------
A few more comments..
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment123123>
Remove the 'is' in the first sentence.
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment123124>
Same as above.
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment123112>
Miss-match should have one 's'
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment123113>
Why did you remove the super.cleanup() call ?
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment123115>
This error looks different from what we throw for IterOutcome.NONE in other operators...can you check and make this consistent.
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java
<https://reviews.apache.org/r/31707/#comment123129>
I think referencing the 2207 JIRA is misleading here because that one will be marked Fixed once this feature goes in. To avoid confusion, this should either refer to a specific star column bug or not reference the jira.
- Aman Sinha
On March 7, 2015, 2:28 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31707/
> -----------------------------------------------------------
>
> (Updated March 7, 2015, 2:28 a.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2207
> https://issues.apache.org/jira/browse/DRILL-2207
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2207: New Union-All Implementation
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
> exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
> exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31707/diff/
>
>
> Testing
> -------
>
> Design Doc can be found from:
> https://issues.apache.org/jira/browse/DRILL-2207
>
> Unit, Customers, TPCH passed
> waiting for Functional...
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/
-----------------------------------------------------------
(Updated March 7, 2015, 2:28 a.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
throw DrillRuntime exception if there is no appropriate implicit casting
Bugs: DRILL-2207
https://issues.apache.org/jira/browse/DRILL-2207
Repository: drill-git
Description
-------
DRILL-2207: New Union-All Implementation
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/31707/diff/
Testing
-------
Design Doc can be found from:
https://issues.apache.org/jira/browse/DRILL-2207
Unit, Customers, TPCH passed
waiting for Functional...
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/
-----------------------------------------------------------
(Updated March 7, 2015, 12:49 a.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
fix
Bugs: DRILL-2207
https://issues.apache.org/jira/browse/DRILL-2207
Repository: drill-git
Description
-------
DRILL-2207: New Union-All Implementation
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/31707/diff/
Testing
-------
Design Doc can be found from:
https://issues.apache.org/jira/browse/DRILL-2207
Unit, Customers, TPCH passed
waiting for Functional...
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On March 6, 2015, 10:45 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 62
> > <https://reviews.apache.org/r/31707/diff/2/?file=885179#file885179line62>
> >
> > This should ideally be just UnionAll. Is an import missing ?
Initially, there is another class (the Runtime Code Generation template for union all) also called unionall, so package name is used to differentiate; Now I change the former one to UnionAller.
> On March 6, 2015, 10:45 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 241
> > <https://reviews.apache.org/r/31707/diff/2/?file=885179#file885179line241>
> >
> > Won't this convert to nullable even if the desired output type is non-nullable ?
> > Also, I think in general most of this logic for deciding the casting should live outside of the UnionAll code in some common utility class such that it is used by multiple operators.
Move this part of code to ExpressionTreeMaterializer; after all, addCastExpression() method has been in this this class.
> On March 6, 2015, 10:45 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 288
> > <https://reviews.apache.org/r/31707/diff/2/?file=885179#file885179line288>
> >
> > Can you run some tests with TPCH SF1 such that we are testing with larger numbers of record batches ? Also test a case where left side has 0 rows, right side has non-zero.
1. [TPCH SF1] A bunch of tests were tested on TPCH SF1; Looked fine
2. [Either side with 0 rows] Worked as we expected; To sum up again, no matter which side has no record, the output schema always follows the left side
> On March 6, 2015, 10:45 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 361
> > <https://reviews.apache.org/r/31707/diff/2/?file=885179#file885179line361>
> >
> > You should identify whether the schema change occurred on left or right input. Pls change the error to a clearer one, e.g "Schema change detected in <left/right> input of Union-All. This is not currently supported."
More appropriate exception message is given
> On March 6, 2015, 10:45 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java, line 150
> > <https://reviews.apache.org/r/31707/diff/2/?file=885182#file885182line150>
> >
> > Error message should be clearer: "Union-all over schema-less tables must specify the columns explicitly"
More appropriate exception message is given
> On March 6, 2015, 10:45 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java, line 51
> > <https://reviews.apache.org/r/31707/diff/2/?file=885183#file885183line51>
> >
> > Is this going to force a Project on the right side even if the column names, ordinals and number of columns are the same as the ones on the left side ? I think we should avoid passing a 'force' flag here.
This field is actually necessary. I took it off by adding another if-statement before calling this method
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/#review75407
-----------------------------------------------------------
On March 7, 2015, 12:49 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31707/
> -----------------------------------------------------------
>
> (Updated March 7, 2015, 12:49 a.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2207
> https://issues.apache.org/jira/browse/DRILL-2207
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2207: New Union-All Implementation
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
> exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
> exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31707/diff/
>
>
> Testing
> -------
>
> Design Doc can be found from:
> https://issues.apache.org/jira/browse/DRILL-2207
>
> Unit, Customers, TPCH passed
> waiting for Functional...
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/#review75407
-----------------------------------------------------------
Sending some initial comments.
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment122444>
This should ideally be just UnionAll. Is an import missing ?
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment122737>
Won't this convert to nullable even if the desired output type is non-nullable ?
Also, I think in general most of this logic for deciding the casting should live outside of the UnionAll code in some common utility class such that it is used by multiple operators.
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment122743>
Can you run some tests with TPCH SF1 such that we are testing with larger numbers of record batches ? Also test a case where left side has 0 rows, right side has non-zero.
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
<https://reviews.apache.org/r/31707/#comment122729>
You should identify whether the schema change occurred on left or right input. Pls change the error to a clearer one, e.g "Schema change detected in <left/right> input of Union-All. This is not currently supported."
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java
<https://reviews.apache.org/r/31707/#comment122538>
Error message should be clearer: "Union-all over schema-less tables must specify the columns explicitly"
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java
<https://reviews.apache.org/r/31707/#comment122728>
Is this going to force a Project on the right side even if the column names, ordinals and number of columns are the same as the ones on the left side ? I think we should avoid passing a 'force' flag here.
- Aman Sinha
On March 5, 2015, 12:27 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31707/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 12:27 a.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2207
> https://issues.apache.org/jira/browse/DRILL-2207
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2207: New Union-All Implementation
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAll.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllTemplate.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
> exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
> exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q9.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31707/diff/
>
>
> Testing
> -------
>
> Design Doc can be found from:
> https://issues.apache.org/jira/browse/DRILL-2207
>
> Unit, Customers, TPCH passed
> waiting for Functional...
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/
-----------------------------------------------------------
(Updated March 5, 2015, 12:27 a.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
Use unordered comparisions for test frameworks and also fix DRILL-1923
Bugs: DRILL-2207
https://issues.apache.org/jira/browse/DRILL-2207
Repository: drill-git
Description
-------
DRILL-2207: New Union-All Implementation
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAll.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllTemplate.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java 270462b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java baf74b1
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q9.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/31707/diff/
Testing
-------
Design Doc can be found from:
https://issues.apache.org/jira/browse/DRILL-2207
Unit, Customers, TPCH passed
waiting for Functional...
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On March 3, 2015, 11:07 p.m., Jason Altekruse wrote:
> > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java, line 37
> > <https://reviews.apache.org/r/31707/diff/1/?file=883700#file883700line37>
> >
> > Change all of these to unordered comparisions, there is no guarentee about the ordering in the case of a union all (also even though reads on a single file will produce an ordered result currently we shouldn't rely on it when writing tests)
will upload the new patch in one sec
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/#review75077
-----------------------------------------------------------
On March 3, 2015, 10:37 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31707/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 10:37 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2207
> https://issues.apache.org/jira/browse/DRILL-2207
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2207: New Union-All Implementation
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAll.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllTemplate.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
> exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java 7b772cc
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
> exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q9.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31707/diff/
>
>
> Testing
> -------
>
> Design Doc can be found from:
> https://issues.apache.org/jira/browse/DRILL-2207
>
> Unit, Customers, TPCH passed
> waiting for Functional...
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/#review75077
-----------------------------------------------------------
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
<https://reviews.apache.org/r/31707/#comment122013>
Change all of these to unordered comparisions, there is no guarentee about the ordering in the case of a union all (also even though reads on a single file will produce an ordered result currently we shouldn't rely on it when writing tests)
- Jason Altekruse
On March 3, 2015, 10:37 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31707/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 10:37 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2207
> https://issues.apache.org/jira/browse/DRILL-2207
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2207: New Union-All Implementation
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAll.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllTemplate.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
> exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java 7b772cc
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
> exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
> exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionAll/q9.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31707/diff/
>
>
> Testing
> -------
>
> Design Doc can be found from:
> https://issues.apache.org/jira/browse/DRILL-2207
>
> Unit, Customers, TPCH passed
> waiting for Functional...
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/
-----------------------------------------------------------
(Updated March 3, 2015, 10:37 p.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Bugs: DRILL-2207
https://issues.apache.org/jira/browse/DRILL-2207
Repository: drill-git
Description
-------
DRILL-2207: New Union-All Implementation
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAll.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllTemplate.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java 7b772cc
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q9.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/31707/diff/
Testing (updated)
-------
Design Doc can be found from:
https://issues.apache.org/jira/browse/DRILL-2207
Unit, Customers, TPCH passed
waiting for Functional...
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 31707: DRILL-2207: New Union-All Implementation
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31707/
-----------------------------------------------------------
(Updated March 3, 2015, 10:37 p.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
DRILL-2207
Bugs: DRILL-2207
https://issues.apache.org/jira/browse/DRILL-2207
Repository: drill-git
Description
-------
DRILL-2207: New Union-All Implementation
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java 3565bf4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAll.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 99aec92
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllTemplate.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java 4c9d301
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 60a9e4b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java dcd5ebf
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java 7b772cc
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java f5b0de4
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 225b21e
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b
exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionAll/q9.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/31707/diff/
Testing (updated)
-------
Design Doc can be found from:
https://issues.apache.org/jira/browse/DRILL-2207
Unit, Customers, TPCH, Functional (still waiting ...)
Thanks,
Sean Hsuan-Yi Chu