[jira] Commented: (HADOOP-2857) libhdfs: no way to set JVM args other than classpath

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590177#action_12590177 ] 

Hadoop QA commented on HADOOP-2857:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12380413/v2.patch.libhdfs.jvm.args
against trunk revision 645773.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2266/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2266/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2266/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2266/console

This message is automatically generated.

> libhdfs: no way to set JVM args other than classpath
> ----------------------------------------------------
>
>                 Key: HADOOP-2857
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2857
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.16.0
>            Reporter: Craig Macdonald
>            Priority: Minor
>         Attachments: patch.libhdfs.jvm.args, v2.patch.libhdfs.jvm.args
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> I would like a way to set other Java system properties and/or other Java VM arguments when using libhdfs - i.e. I want to be able to say start a profiler, attach a debugger, or increase the memory available to the VM.
> At present, new JVMs are initialised from the getJNIEnv(void) method in src/c++/libhdfs/hdfsJniHelper.c
> This method initialises the -Djava.class.path JVM argument from the CLASSPATH environment variable. I am proposing that another env variable should be added, the contents of which is passed (almost) verbatim as JVM arguments.
> Eg, say the env var JVM_ARGS is used. The string from the env var would be tokenised on "one or more spaces", and would be passed as additional JVM arguments, by make a larger JavaVMOption options[] array, and setting vm_args.nOptions = 1+ number of passed arguments.
> Only flaw I can see with this is that none of the passed parameters can contain spaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.