You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@cguru.net> on 2015/09/09 05:15:05 UTC
Review Request 38201: [MESOS-1187] precision errors with allocation
calculations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38201/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1187
https://issues.apache.org/jira/browse/MESOS-1187
Repository: mesos
Description
-------
As allocations are stored/transmitted as doubles many a times precision errors creep in.
Diffs
-----
src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f
src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
Diff: https://reviews.apache.org/r/38201/diff/
Testing
-------
make
make check
Thanks,
Klaus Ma
Re: Review Request 38201: [MESOS-1187] precision errors with
allocation calculations
Posted by Klaus Ma <kl...@cguru.net>.
> On Sept. 9, 2015, 3:46 a.m., Guangya Liu wrote:
> > I think that the V1 related should also be updated.
Agree with that; I'll address that if no comments on the algorithm. And I've logged a JIRA to address duplicated codes.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38201/#review98145
-----------------------------------------------------------
On Sept. 9, 2015, 6:04 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38201/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 6:04 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1187
> https://issues.apache.org/jira/browse/MESOS-1187
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As allocations are stored/transmitted as doubles many a times precision errors creep in.
>
>
> Diffs
> -----
>
> src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f
> src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
>
> Diff: https://reviews.apache.org/r/38201/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 38201: [MESOS-1187] precision errors with
allocation calculations
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38201/#review98145
-----------------------------------------------------------
I think that the V1 related should also be updated.
- Guangya Liu
On 九月 9, 2015, 3:15 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38201/
> -----------------------------------------------------------
>
> (Updated 九月 9, 2015, 3:15 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1187
> https://issues.apache.org/jira/browse/MESOS-1187
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As allocations are stored/transmitted as doubles many a times precision errors creep in.
>
>
> Diffs
> -----
>
> src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f
> src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
>
> Diff: https://reviews.apache.org/r/38201/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>