You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2019/02/18 19:43:01 UTC

[jira] [Commented] (HADOOP-15870) S3AInputStream.remainingInFile should use nextReadPos

    [ https://issues.apache.org/jira/browse/HADOOP-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771329#comment-16771329 ] 

Steve Loughran commented on HADOOP-15870:
-----------------------------------------

HADOOP-15870. S3AInputStream.remainingInFile should use nextReadPos  patch 004

Takes patch 003, applies to trunk and then

* specified what availalble should do, highlighting where GZip's expectations diverge from the Java API requirements
* Seek test has specific available tests factored for better readability and reporting
* S3A input stream semantics become: "return 0 on closed/past end of file; 1 when no stream is open, else wrappedStream.available()

The previous patch was slightly flawed in that reading a file > 2^32 bytes long then MAX_INT would be returned, rather than the avaialable set)

> S3AInputStream.remainingInFile should use nextReadPos
> -----------------------------------------------------
>
>                 Key: HADOOP-15870
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15870
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.8.4, 3.1.1
>            Reporter: Shixiong Zhu
>            Assignee: lqjacklee
>            Priority: Major
>         Attachments: HADOOP-15870-002.patch, HADOOP-15870-003.patch, HADOOP-15870-004.patch
>
>
> Otherwise `remainingInFile` will not change after `seek`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org