You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2022/06/22 21:18:00 UTC
[jira] [Commented] (CASSANDRA-16911) Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest
[ https://issues.apache.org/jira/browse/CASSANDRA-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557707#comment-17557707 ]
Stefan Miklosovic commented on CASSANDRA-16911:
-----------------------------------------------
Thanks for the initial review [~paulo] . I want to expand on what I did.
You were asking in PR if we should include ephemeral snapshots into SnapshotManager or not. This begs for a bigger question to be asked though. Should not we add _all_ snapshots in there? I am not sure what plans you have with SnapshotManager but right now it just, practically, holds ttl snapshots and thats it. The primary reason I would like to track all snapshots in the manager is that when we are doing listing of snapshots (invoked every time on nodetool listsnaphots) it goes via SnapshotLoader. This walks the disk unnecessarily. Can not we just hold all snapshots in SnapshotManager so we do not need to walk it every time? Should be faster too.
Also, when we start to track ephemerals in SnapshotManager, when repair removes ephemerals, we need to remove them from the SnapshotManager too.
Would you please take a second look at the PR? I added a lot of stuff you asked for.
> Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-16911
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16911
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.2
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> While creating an ephemeral snapshot, a marker file is created at disk in a respective snapshot directory. This is not necessary anymore as we have introduced SnapshotManifest in CASSANDRA-16789 so we can move this flag there. By putting the information if a snapshot is ephemeral or not into SnapshotManifest, we simplify and "clean up" the snapshotting process and related codebase.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org