You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/25 02:45:36 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #371: Add code spell check to checkpatch.sh

xiaoxiang781216 opened a new pull request #371: Add code spell check to checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/371
 
 
   Enable by -c option

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #371: Add code spell check to checkpatch.sh

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #371: Add code spell check to checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/371#issuecomment-590838878
 
 
   @xiaoxiang781216 What version and where is codespell and is there a dictionary for nuttx for it? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #371: Add code spell check to checkpatch.sh

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #371: Add code spell check to checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/371#issuecomment-590850444
 
 
   I use the version installed by command:
   pip install codespell
   here is the offical repo:
   https://github.com/codespell-project/codespell
   The dictionary come from the installation which is also used by Linux kernel's checkpatch.pl.
   There still has few false alarm, we just need add a small NuttX specifc blacklist to ignore these word, then we can even enable it by default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] Ouss4 merged pull request #371: Add code spell check to checkpatch.sh

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #371: Add code spell check to checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/371
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #371: Add code spell check to checkpatch.sh

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #371: Add code spell check to checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/371#issuecomment-590850444
 
 
   I use the version installed by command:
   pip install codespell
   here is the offical repo:
   https://github.com/codespell-project/codespell
   The dictionary come from the installation which is also used by Linux kernel's checkpatch.pl.
   There still has few false alarm, we just need add a small NuttX specifc blacklist to ignore these words, then we can even enable it in checkpatch.sh by default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #371: Add code spell check to checkpatch.sh

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #371: Add code spell check to checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/371#issuecomment-590655273
 
 
   The error found by codespell in the current codebase is here:
   https://github.com/apache/incubator-nuttx/pull/362
   https://github.com/apache/incubator-nuttx/pull/357
   https://github.com/apache/incubator-nuttx-apps/pull/90
   https://github.com/apache/incubator-nuttx-apps/pull/89

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services