[jira] [Commented] (FLINK-23491) Scheduler benchmarks are not running

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-23491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387322#comment-17387322 ] 

Chesnay Schepler commented on FLINK-23491:
------------------------------------------

The problem was that the test-jars for both flink-runtime_2.11 and flink-runtime (without a suffix) were put on the classpath, because the poms were not updated after the removal of the suffix.

> Scheduler benchmarks are not running
> ------------------------------------
>
>                 Key: FLINK-23491
>                 URL: https://issues.apache.org/jira/browse/FLINK-23491
>             Project: Flink
>          Issue Type: Bug
>          Components: Benchmarks, Runtime / Coordination
>            Reporter: Zhilong Hong
>            Assignee: Chesnay Schepler
>            Priority: Critical
>              Labels: pull-request-available
>
> As shown in [codespeed|http://codespeed.dak8s.net:8000/timeline/#/?exe=5&env=2&revs=1000&equid=off&quarts=on&extr=on&ben=grid], we find that the scheduler benchmark are not running from July 22nd to July 25th. The last valid commit revision is fce9c1d8. I try to run the scheduler benchmarks locally and find that they work well. 
> I've checked the log and find that the scheduler benchmarks are not running because:
> {code:java}
> java.lang.NoClassDefFoundError: org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl
> 	at org.apache.flink.scheduler.benchmark.e2e.CreateSchedulerBenchmarkExecutor.setup(CreateSchedulerBenchmarkExecutor.java:51)
> 	at org.apache.flink.scheduler.benchmark.e2e.generated.CreateSchedulerBenchmarkExecutor_createScheduler_jmhTest._jmh_tryInit_f_createschedulerbenchmarkexecutor0_0(CreateSchedulerBenchmarkExecutor_createScheduler_jmhTest.java:342)
> 	at org.apache.flink.scheduler.benchmark.e2e.generated.CreateSchedulerBenchmarkExecutor_createScheduler_jmhTest.createScheduler_SingleShotTime(CreateSchedulerBenchmarkExecutor_createScheduler_jmhTest.java:294)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:453)
> 	at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:437)
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 	at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.ClassNotFoundException: org.apache.flink.runtime.jobmaster.slotpool.SlotPoolImpl
> 	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> 	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> 	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> 	... 15 more{code}
> It seems that the benchmarks are still calling {{SlotPoolImpl}}, which is removed in FLINK-22477. But it's weird that {{SlotPoolImpl}} is removed on July 13th, while the benchmark is not running until July 22nd. I think maybe it's related to JMH?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)