You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/23 21:00:53 UTC

[GitHub] [spark] brkyvz opened a new pull request #25569: [SPARK-28863] Introduce AlreadyPlanned, a node that speeds-up planning

brkyvz opened a new pull request #25569: [SPARK-28863] Introduce AlreadyPlanned, a node that speeds-up planning
URL: https://github.com/apache/spark/pull/25569
 
 
   ### What changes were proposed in this pull request?
   
   This PR introduces a LogicalNode AlreadyPlanned, and related physical plan and preparation rule.
   
   With the DataSourceV2 write operations, we have a way to fallback to the V1 writer APIs using InsertableRelation. The gross part is that we're in physical land, but the InsertableRelation takes a logical plan, so we have to pass the logical plans to these physical nodes, and then potentially go through re-planning.
   
   A useful primitive could be specifying that a plan is ready for execution through a logical node AlreadyPlanned. This would wrap a physical plan, and then we can go straight to execution. In addition, if you have queries which you re-run over again with minor parameter changes, you can leverage this node to avoid re-planning potentially huge query plans. An example of this could be Parametrized Views in SQL Server.
   
   ### Why are the changes needed?
   
   It's a good to have.
   
   ### Does this PR introduce any user-facing change?
   
   Nope
   
   ### How was this patch tested?
   
   V1FallbackWriterSuite tests that writes still work, and we also introduce AlreadyPlannedSuite

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org