You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksey Yeschenko (Jira)" <ji...@apache.org> on 2019/09/20 22:55:00 UTC
[jira] [Commented] (CASSANDRA-15163) Untangle RepairMessage
sub-hierarchy of messages, use new messaging (more) correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934805#comment-16934805 ]
Aleksey Yeschenko commented on CASSANDRA-15163:
-----------------------------------------------
Committed as [f9ff88437742675db5c53f5834884b43f8937e00|https://github.com/apache/cassandra/commit/f9ff88437742675db5c53f5834884b43f8937e00] to trunk, cheers.
> Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15163
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15163
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Normal
> Fix For: 4.0
>
>
> There is currently a nested sub-hierarchy of messages used by repair - in {{RepairMessage}} - all sharing one verb, all sharing one deserialiser, all sharing one verb handler. The first two can and should be addressed, and it’s mostly a mechanical task to do so. The last one should be tackled separately, when we get to refactor repair some day (and it could definitely use some love).
> The proposed patch follows-up the work done in CASSANDRA-15066 and makes repair use the new messaging service in a more correct way, making verbs and deserialization more explicit. It wasn't included into the original commit so that to not make the single commit larger that it needed to be.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org