You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2021/05/20 08:43:00 UTC

[jira] [Commented] (FLINK-22721) Breaking HighAvailabilityServices interface by adding new method

    [ https://issues.apache.org/jira/browse/FLINK-22721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348154#comment-17348154 ] 

Chesnay Schepler commented on FLINK-22721:
------------------------------------------

What exact guarantees do we provide for this interface? It's not tagged as an API (so maybe let's add {{@PublicEvolving}}?) and it exposes various various other interfaces (BlobStore, JobGraphStore, LeaderRetrievalService, and further down even the JobGraph); are we just maintaining compatibility on a best-effort basis?

> Breaking HighAvailabilityServices interface by adding new method
> ----------------------------------------------------------------
>
>                 Key: FLINK-22721
>                 URL: https://issues.apache.org/jira/browse/FLINK-22721
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.14.0, 1.13.1, 1.12.5
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Critical
>             Fix For: 1.14.0, 1.13.1, 1.12.5
>
>
> As part of FLINK-20695 we introduced a new method to the {{HighAvailabilityServices.cleanupJobData}} interface. Since this method has not default implementation it is currently breaking change. Since Flink allows to implement custom Ha services using this interface, I suggest adding a default implementation for this method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)