You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "tengu-alt (via GitHub)" <gi...@apache.org> on 2024/11/27 13:59:04 UTC

[PR] Native protocol spec fix [cassandra]

tengu-alt opened a new pull request, #3714:
URL: https://github.com/apache/cassandra/pull/3714

   This PR provides fixes for the `native_protocol_v3.spec` and  `native_protocol_v5.spec` files which contain typos. 
   (e.g  https://github.com/apache/cassandra/blob/trunk/doc/native_protocol_v3.spec#L719-L740)
    
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-20117 Native protocol spec fix [cassandra]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #3714:
URL: https://github.com/apache/cassandra/pull/3714#issuecomment-2679832182

   Committed as https://github.com/apache/cassandra/commit/17de6a67a2399226aaf84e5826af14ef6a7c507e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-20117 Native protocol spec fix [cassandra]

Posted by "tengu-alt (via GitHub)" <gi...@apache.org>.
tengu-alt commented on PR #3714:
URL: https://github.com/apache/cassandra/pull/3714#issuecomment-2677870766

   > I had to add this commit
   
   Got it! I have a small question about that squash, why do we need to clone Cassandra from my fork?
   And in general, does it need anything else from me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-20117 Native protocol spec fix [cassandra]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever closed pull request #3714: CASSANDRA-20117 Native protocol spec fix
URL: https://github.com/apache/cassandra/pull/3714


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-20117 Native protocol spec fix [cassandra]

Posted by "tengu-alt (via GitHub)" <gi...@apache.org>.
tengu-alt commented on PR #3714:
URL: https://github.com/apache/cassandra/pull/3714#issuecomment-2590061154

   The `:toc:` line was removed because the page displays another one.
    
   ![image](https://github.com/user-attachments/assets/1bbf831e-ec04-47c1-9071-f959496d1e2c)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-20117 Native protocol spec fix [cassandra]

Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #3714:
URL: https://github.com/apache/cassandra/pull/3714#issuecomment-2679796321

   > Got it, thank you! I have a small question about that squash, why do we need to clone Cassandra from my fork?
   
   That was just during testing (to grab `cqlprotodoc`)
   
   > And in general, does it need anything else from me?
   
   nothing, merging it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSANDRA-20117 Native protocol spec fix [cassandra]

Posted by "tengu-alt (via GitHub)" <gi...@apache.org>.
tengu-alt commented on PR #3714:
URL: https://github.com/apache/cassandra/pull/3714#issuecomment-2681366137

   > nothing, merging it now.
   
   Got it. Thank you!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org