You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/04 07:14:49 UTC
[GitHub] [inlong] gong opened a new pull request, #5354: [INLONG-5353][Sort] Fix HBase connector packaging problem and inlong metrics delimiter problem
gong opened a new pull request, #5354:
URL: https://github.com/apache/inlong/pull/5354
### Prepare a Pull Request
- [INLONG-5353][Sort] Fix HBase connector packaging problem and inlong metrics delimiter problem
- Fixes #5353
### Motivation
Fix HBase connector packaging problem and inlong metrics delimiter problem
### Modifications
* modify HBase connector pom file
* modify HBase connector delimiter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #5354: [INLONG-5353][Sort] Fix HBase connector packaging problem and inlong metrics delimiter problem
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5354:
URL: https://github.com/apache/inlong/pull/5354#discussion_r937438648
##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -128,18 +129,18 @@ public void open(Configuration parameters) throws Exception {
this.runtimeContext = getRuntimeContext();
sinkMetricData = new SinkMetricData(runtimeContext.getMetricGroup());
Review Comment:
here if sinkMetricData would throw npe if inlongMetrics is null. So the initialization should be after the check of inlongMetrics.
if (inLongMetric != null && !inLongMetric.isEmpty()) { new sinkMetricData ... }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #5354: [INLONG-5353][Sort] Fix HBase connector packaging problem and inlong metrics delimiter problem
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5354:
URL: https://github.com/apache/inlong/pull/5354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org