You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/11 07:06:22 UTC
[GitHub] [camel-k] bouskaJ opened a new pull request, #3537: Olm image test 1.8.x
bouskaJ opened a new pull request, #3537:
URL: https://github.com/apache/camel-k/pull/3537
- stabilize upgrade test (Patch the Subscription to avoid conflicts with concurrent updates performed by OLM)
- test operator image installed by the OLM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3537: Olm image test 1.8.x
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3537:
URL: https://github.com/apache/camel-k/pull/3537#discussion_r964370969
##########
pkg/util/defaults/defaults_support.go:
##########
@@ -28,6 +29,10 @@ func BaseImage() string {
return envOrDefault(baseImage, "KAMEL_BASE_IMAGE", "RELATED_IMAGE_BASE")
}
+func OperatorImage() string {
+ return envOrDefault(fmt.Sprintf("%s:%s", ImageName, Version), "KAMEL_OPERATOR_IMAGE", "KAMEL_K_TEST_OPERATOR_CURRENT_IMAGE")
Review Comment:
It doesn't look good that a test env is leaked to the main codebase, but since it's only for 1.8 then it should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi merged pull request #3537: Olm image test 1.8.x
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3537:
URL: https://github.com/apache/camel-k/pull/3537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #3537: Olm image test 1.8.x
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on PR #3537:
URL: https://github.com/apache/camel-k/pull/3537#issuecomment-1232523454
@squakez can you review this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org