[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5064: Geode-8082: Refactor (reformat and renames) in GeodeRedisServer file in Geode-Redis-Module

[GitBox <gi...@apache.org>]

jdeppe-pivotal commented on a change in pull request #5064:
URL: https://github.com/apache/geode/pull/5064#discussion_r421507630



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/GeodeRedisServer.java
##########
@@ -596,61 +596,121 @@ public Thread newThread(Runnable r) {
 
     bossGroup = null;
     workerGroup = null;
+
     Class<? extends ServerChannel> socketClass;
     if (singleThreadPerConnection) {
       socketClass =
-          startRedisServiceSingleThreadPerConnection(selectorThreadFactory, workerThreadFactory);
+          startRedisServiceSingleThreadPerConnection(
+              selectorThreadFactory,
+              workerThreadFactory);
     } else {
-      bossGroup = new NioEventLoopGroup(numSelectorThreads, selectorThreadFactory);
-      workerGroup = new NioEventLoopGroup(numWorkerThreads, workerThreadFactory);
+      bossGroup =
+          new NioEventLoopGroup(numSelectorThreads, selectorThreadFactory);
+      workerGroup =
+          new NioEventLoopGroup(numWorkerThreads, workerThreadFactory);
+

Review comment:
       I realize this is perhaps a very personal preference, but I really dislike breaking up assignments (or method calls) like this when the line itself isn't really very long and doesn't already hit the max line length for code style. I find it makes methods longer such that I end up having to scroll back and forth to read the method. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org