[jira] [Commented] (PHOENIX-102) IndexMaintainer constructor doesn't set isMultiTenant correctly

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918394#comment-13918394 ] 

James Taylor commented on PHOENIX-102:
--------------------------------------

Nice find, [~jeffreyz]. The tenantId should never be an empty pname (but it often was). I've fixed this and added a precondition check too (and use dataTable.isMultiTenant() too as you suggested for that case).

> IndexMaintainer constructor doesn't set isMultiTenant correctly
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-102
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-102
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>
> Currently IndexMaintainer is using 
> {code}
> PName tenantId = dataTable.getTenantId();
> this.isMultiTenant = tenantId != null
> {code}
> The check "tenantId != null" doesn't cover the case tenantId could be empty pname value. In addition, dataTable.isMultiTenant has already exposed right value so we should use dataTable.isMultiTenant() instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)