You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/27 14:24:09 UTC

[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on pull request #202: [YUNIKORN-449] Added MatchNodeSelectorPred to reservation predicates list

kingamarton commented on pull request #202:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/202#issuecomment-717280095


   > hi @kingamarton the change looks good to me. Could you please try to verify this in on your real K8s setup to ensure it works as expected? Thanks!
   
   @yangwwei, I tested it in my local setup and it worked only if I passed in the predicates, so I extended the predicate list for the default scheduling policy as well. After the change the reservation is not created if the nodeLabels are not matching and the pod remains in Pending state.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org