You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2015/04/03 02:06:04 UTC

[GitHub] spark pull request: [SQL][SPARK-5453] Use property 'mapreduce.inpu...

Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/4246#issuecomment-89087051
  
    Sorry for the delay reviewing this.  At a high level this seems like a reasonable thing to support.  I'd suggest that we consolidate the logic for constructing the `Option[PathFilter]` into a single location in `SQLConf` instead of duplicating it.  We should also document that we support his property in the programming guide and audit the code base to make sure we aren't missing any places where we list files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org