[GitHub] [activemq-artemis] brusdev commented on a change in pull request #2749: ARTEMIS-2408 Too many opened FDs after server stops

[GitBox <gi...@apache.org>]

brusdev commented on a change in pull request #2749: ARTEMIS-2408 Too many opened FDs after server stops
URL: https://github.com/apache/activemq-artemis/pull/2749#discussion_r303763975
 
 

 ##########
 File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTestSupport.java
 ##########
 @@ -57,6 +57,11 @@
 import org.apache.activemq.artemis.spi.core.remoting.Acceptor;
 import org.apache.activemq.artemis.spi.core.security.ActiveMQJAASSecurityManager;
 import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.fusesource.hawtdispatch.DispatchPriority;
 
 Review comment:
   FuseMQTTClientProvider (already used by some MQTT tests) has a transitive dependency for org.fusesource.hawtdispatch: HawtDispatcher is statically allocated by DispatcherConfig when org.fusesource.mqtt.client.MQTT.blockingConnection is called and It create a new GlobalDispatchQueue.
   I used org.fusesource.hawtdispatch only to shuthdown the global queue at the end of the test to avoid file descriptor leaks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services