[GitHub] [arrow] zeroshade commented on a diff in pull request #35690: GH-35684: [Go][Parquet] Fix nil dereference with nil list array

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #35690:
URL: https://github.com/apache/arrow/pull/35690#discussion_r1199387889


##########
go/parquet/pqarrow/encode_arrow.go:
##########
@@ -246,6 +246,10 @@ type binary64arr interface {
 }
 
 func writeDenseArrow(ctx *arrowWriteContext, cw file.ColumnChunkWriter, leafArr arrow.Array, defLevels, repLevels []int16, maybeParentNulls bool) (err error) {
+	if leafArr.Len() == 0 {

Review Comment:
   Turns out you're right and it ended up causing a different test to fail. So it looks like i just needed to add the checks for whether or not the buffer is nil *sigh*. I've updated this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org