You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "wanjoc (via GitHub)" <gi...@apache.org> on 2023/10/14 18:34:20 UTC
[PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
wanjoc opened a new pull request, #25646:
URL: https://github.com/apache/superset/pull/25646
### SUMMARY
Added alternative instructions on setting SECRET_KEY via environment variables.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
<img width="934" alt="Screen Shot 2023-10-14 at 1 33 20 PM" src="https://github.com/apache/superset/assets/85894801/b15eb536-d7a7-4748-95a8-30ae5de2da81">
<img width="928" alt="Screen Shot 2023-10-14 at 1 33 38 PM" src="https://github.com/apache/superset/assets/85894801/d4dc82c3-dcae-45df-bf04-2ea4dcea2012">
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "wanjoc (via GitHub)" <gi...@apache.org>.
wanjoc commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-1765119033
@sfirke Hello, many users have encountered the error below(ex: [https://github.com/apache/superset/discussions/23598](https://github.com/apache/superset/discussions/23598)). While the initial 'Configuring Superset' section does touch upon setting the SUPERSET_SECRET_KEY environment variable, I believe providing this explicit alternative would make the local setup process more straightforward for beginners. Additionally, I realize this documentation update doesn't directly address the issues some users face with superset re-encrypt-secrets and the PREVIOUS_SECRET_KEY setting. However, I felt this change was a step towards simplifying the initial setup for new users.
<img width="569" alt="Screen Shot 2023-10-16 at 2 11 42 PM" src="https://github.com/apache/superset/assets/85894801/122f5838-95c5-4a4b-92d6-0172bba313b9">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-1765056050
Hello, thanks for the PR and showing the before/after screenshots. Can you please explain what the advantage to this is / what the improvement is here? It seems like another way of adding the value to `superset_config.py`, which is already covered, and I'm not sure this will persist through the machine restarting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-1766734941
`SUPERSET_SECRET_KEY` environment variable is already supported https://github.com/apache/superset/blob/master/superset/config.py#L184
so those additional imports are not required. Just defining the environment variable is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-4255894675
@copilot resolve the merge conflicts in this pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-2822530783
Sorry this seems to have slipped through the cracks, but it's in need of a rebase. I'll mark it as draft mode for now while it awaits an update. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-4256134152
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 477e66604606fc618061cb78cbc47aac0e7d8547 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69e0131d6553800008e9c3ef |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-25646--superset-docs-preview.netlify.app](https://deploy-preview-25646--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-25646--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-1767776236
@sfirke please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "wanjoc (via GitHub)" <gi...@apache.org>.
wanjoc commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-1767368330
@mdeshmu Thank you for the feedback. I've made the suggested update. Tweaked it to include macOS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #25646:
URL: https://github.com/apache/superset/pull/25646#issuecomment-4265198511
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: Added instructions on configuring Superset SECRET_KEY [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #25646:
URL: https://github.com/apache/superset/pull/25646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org