[GitHub] mistercrunch commented on a change in pull request #5100: Fix form data issue switching viz types

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5100: Fix form data issue switching viz types
URL: https://github.com/apache/incubator-superset/pull/5100#discussion_r203454209
 
 

 ##########
 File path: superset/assets/src/explore/store.js
 ##########
 @@ -104,13 +104,6 @@ export function applyDefaultFormData(form_data) {
       formData[k] = form_data[k];
     }
   });
-  // fill in additional params stored in form_data but not used by control
-  Object.keys(form_data)
 
 Review comment:
   Doing forensics here: @graceguo-supercat added this as part of `[Explore] Save custom url parameters when user save slices (#4578)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org